Re: [Qemu-devel] [PATCH 3/4] qmp-shell: don't show version greeting if unavailable

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

On 05/04/2017 07:54 AM, Marc-André Lureau wrote:
> qemu-ga doesn't have greeting.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  scripts/qmp/qmp-shell | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
> index 04b8fa3eae..db24c87cdd 100755
> --- a/scripts/qmp/qmp-shell
> +++ b/scripts/qmp/qmp-shell
> @@ -265,6 +265,9 @@ class QMPShell(qmp.QEMUMonitorProtocol):
>  
>      def show_banner(self, msg='Welcome to the QMP low-level shell!'):
>          print msg
> +        if not self._greeting:
> +            print 'Connected'
> +            return
>          version = self._greeting['QMP']['version']['qemu']
>          print 'Connected to QEMU %d.%d.%d\n' % (version['major'],version['minor'],version['micro'])
>  
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]