From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bin Meng <bmeng@tinylab.org>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Luc Michel <luc.michel@amd.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Alistair Francis <alistair@alistair23.me>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Jason Wang <jasowang@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, Sai Pavan Boddu <sai.pavan.boddu@amd.com>
Subject: Re: [PATCH for 8.2.1] hw/net: cadence_gem: Fix MDIO_OP_xxx values
Date: Tue, 2 Jan 2024 16:08:52 +0100 [thread overview]
Message-ID: <985e87d6-0f8c-4127-b425-f1efc6034879@linaro.org> (raw)
In-Reply-To: <20240102141803.117631-1-bmeng@tinylab.org>
On 2/1/24 15:18, Bin Meng wrote:
> Testing upstream U-Boot with 'sifive_u' machine we see:
>
> => dhcp
> ethernet@10090000: PHY present at 0
> Could not get PHY for ethernet@10090000: addr 0
> phy_connect failed
>
> This has been working till QEMU 8.1 but broken since QEMU 8.2.
s/till/until/?
> Fixes: 1b09eeb122aa ("hw/net/cadence_gem: use FIELD to describe PHYMNTNC register fields")
> Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
>
> ---
>
> hw/net/cadence_gem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index 296bba238e..472ce9c8cf 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -199,8 +199,8 @@ REG32(PHYMNTNC, 0x34) /* Phy Maintenance reg */
> FIELD(PHYMNTNC, PHY_ADDR, 23, 5)
> FIELD(PHYMNTNC, OP, 28, 2)
> FIELD(PHYMNTNC, ST, 30, 2)
> -#define MDIO_OP_READ 0x3
> -#define MDIO_OP_WRITE 0x2
> +#define MDIO_OP_READ 0x2
> +#define MDIO_OP_WRITE 0x1
>
> REG32(RXPAUSE, 0x38) /* RX Pause Time reg */
> REG32(TXPAUSE, 0x3c) /* TX Pause Time reg */
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-01-02 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 14:18 [PATCH for 8.2.1] hw/net: cadence_gem: Fix MDIO_OP_xxx values Bin Meng
2024-01-02 15:08 ` Philippe Mathieu-Daudé [this message]
2024-01-02 18:32 ` Heinrich Schuchardt
2024-01-02 19:09 ` Philippe Mathieu-Daudé
2024-01-03 11:48 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=985e87d6-0f8c-4127-b425-f1efc6034879@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=bmeng@tinylab.org \
--cc=edgar.iglesias@gmail.com \
--cc=jasowang@redhat.com \
--cc=luc.michel@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sai.pavan.boddu@amd.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).