From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C3D4C47074 for ; Tue, 2 Jan 2024 15:09:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rKgO5-0001hR-2R; Tue, 02 Jan 2024 10:09:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKgO3-0001gx-Fk for qemu-devel@nongnu.org; Tue, 02 Jan 2024 10:08:59 -0500 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rKgO1-0000wk-JK for qemu-devel@nongnu.org; Tue, 02 Jan 2024 10:08:58 -0500 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50e759ece35so7205200e87.3 for ; Tue, 02 Jan 2024 07:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704208135; x=1704812935; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J7Tq9QtgITf1V5dEA4XQbNPEPX/yCoTUWLmNnJyV6yI=; b=xNY8KlsCiKdR/dKI88opLPrm28l03/ZElUnU97UeTexmMT54aXcSSrKTWJ1bnqI0id CbeIe6HadrhHOnVlPWRjsXgTfh4IQKleRJDeIGB4MKisQKKGhkmnZZhSkLPgqgnkg5gu lNkm7h9iJfyX+gudtrahOusLSeLxwhx8gvraJX6HtaSMTkVljBWnE7BJjJWFuclLpqZn FQ594P2swLbcfB+JggZ7ip2NtPgFVWOLeKwQTU1yn7n3PQq0rm96YpTmLrRq0uNJ/DFr JnrTBHmtG6LoVb0l+FE83O2uqnjqltzjtNJfyB3fc24lEBMRsRM99wm01b5bFY/mb/Fr D7sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704208135; x=1704812935; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J7Tq9QtgITf1V5dEA4XQbNPEPX/yCoTUWLmNnJyV6yI=; b=Bzep7Vix/ys7zQkNvRxT1l5j6mVqP65OjLLb1fLRO+2vGS5Pe88TzFAyQX+ck+BhxB DW+9O+utGekEaa4gZCr0gP9LOqIPUjQs4utBnUydV0FovRPw2sgorDTrGH+iNSCaxn7C kO33791MiSYGSWA2Z2M7Brd7L1SQxZ4/BIn1BR+1YobRCjWAFiq+7h/3/VFA5ZkZ3Un+ SrFAn2qXF1qkKLDTUTRGcPe77R2aUNQoJ83GuBRpWnjrhQh5cMjzgi4kXvpFdPTaTTCW Zyp2OGuSvro2bXGKcNyN67LxpduIsJd17wGUhENLCDVqQl/dBeW+W/Id7n5q7iKcoWWU 0TYA== X-Gm-Message-State: AOJu0YyGPGcRNhDosdAGf4zYkvRpwQR1Vxg+HKJTMFFmFnufJf9icLZl MqF5TMDVLYP+00uCzKhGnPk1NEEd0/SNYQ== X-Google-Smtp-Source: AGHT+IGAByqF8gx3Q5Y/SXLiyjnnY7ZEYqkNG8ikWH782h3MP0VLzZWDbJ/rzZdLzn0ZuQaN+iGLKA== X-Received: by 2002:a05:6512:3b83:b0:50e:7b37:d110 with SMTP id g3-20020a0565123b8300b0050e7b37d110mr5949366lfv.16.1704208135402; Tue, 02 Jan 2024 07:08:55 -0800 (PST) Received: from [192.168.69.100] (sal63-h02-176-184-16-71.dsl.sta.abo.bbox.fr. [176.184.16.71]) by smtp.gmail.com with ESMTPSA id qc28-20020a170906d8bc00b00a279b182e42sm4026491ejb.171.2024.01.02.07.08.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jan 2024 07:08:55 -0800 (PST) Message-ID: <985e87d6-0f8c-4127-b425-f1efc6034879@linaro.org> Date: Tue, 2 Jan 2024 16:08:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH for 8.2.1] hw/net: cadence_gem: Fix MDIO_OP_xxx values Content-Language: en-US To: Bin Meng , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Luc Michel Cc: Heinrich Schuchardt , Alistair Francis , "Edgar E. Iglesias" , Jason Wang , Peter Maydell , qemu-arm@nongnu.org, Sai Pavan Boddu References: <20240102141803.117631-1-bmeng@tinylab.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20240102141803.117631-1-bmeng@tinylab.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=philmd@linaro.org; helo=mail-lf1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/1/24 15:18, Bin Meng wrote: > Testing upstream U-Boot with 'sifive_u' machine we see: > > => dhcp > ethernet@10090000: PHY present at 0 > Could not get PHY for ethernet@10090000: addr 0 > phy_connect failed > > This has been working till QEMU 8.1 but broken since QEMU 8.2. s/till/until/? > Fixes: 1b09eeb122aa ("hw/net/cadence_gem: use FIELD to describe PHYMNTNC register fields") > Reported-by: Heinrich Schuchardt > Signed-off-by: Bin Meng > > --- > > hw/net/cadence_gem.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c > index 296bba238e..472ce9c8cf 100644 > --- a/hw/net/cadence_gem.c > +++ b/hw/net/cadence_gem.c > @@ -199,8 +199,8 @@ REG32(PHYMNTNC, 0x34) /* Phy Maintenance reg */ > FIELD(PHYMNTNC, PHY_ADDR, 23, 5) > FIELD(PHYMNTNC, OP, 28, 2) > FIELD(PHYMNTNC, ST, 30, 2) > -#define MDIO_OP_READ 0x3 > -#define MDIO_OP_WRITE 0x2 > +#define MDIO_OP_READ 0x2 > +#define MDIO_OP_WRITE 0x1 > > REG32(RXPAUSE, 0x38) /* RX Pause Time reg */ > REG32(TXPAUSE, 0x3c) /* TX Pause Time reg */ Reviewed-by: Philippe Mathieu-Daudé