From: Eric Auger <eric.auger@redhat.com>
To: JianChunfu <jansef.jian@hj-micro.com>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/arm/smmu-common: Remove the repeated ttb field
Date: Thu, 27 Feb 2025 10:29:58 +0100 [thread overview]
Message-ID: <9863d34f-3244-4d07-996f-c91db5a17ffc@redhat.com> (raw)
In-Reply-To: <20250221031034.69822-1-jansef.jian@hj-micro.com>
Hi,
On 2/21/25 4:10 AM, JianChunfu wrote:
> SMMUTransCfg->ttb is never used in QEMU, TT base address
> can be accessed by SMMUTransCfg->tt[i]->ttb.
>
> Signed-off-by: JianChunfu <jansef.jian@hj-micro.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks!
Eric
> ---
> include/hw/arm/smmu-common.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/arm/smmu-common.h b/include/hw/arm/smmu-common.h
> index d1a4a6455..e5ad55bba 100644
> --- a/include/hw/arm/smmu-common.h
> +++ b/include/hw/arm/smmu-common.h
> @@ -110,7 +110,6 @@ typedef struct SMMUTransCfg {
> /* Used by stage-1 only. */
> bool aa64; /* arch64 or aarch32 translation table */
> bool record_faults; /* record fault events */
> - uint64_t ttb; /* TT base address */
> uint8_t oas; /* output address width */
> uint8_t tbi; /* Top Byte Ignore */
> int asid;
next prev parent reply other threads:[~2025-02-27 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 3:10 [PATCH] hw/arm/smmu-common: Remove the repeated ttb field JianChunfu
2025-02-27 9:29 ` Eric Auger [this message]
2025-03-03 14:09 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9863d34f-3244-4d07-996f-c91db5a17ffc@redhat.com \
--to=eric.auger@redhat.com \
--cc=jansef.jian@hj-micro.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).