From: Harsh Prateek Bora <harshpb@linux.ibm.com>
To: BALATON Zoltan <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v4 02/12] hw/ppc/pegasos2: Remove explicit name properties from device tree
Date: Thu, 23 Oct 2025 10:25:34 +0530 [thread overview]
Message-ID: <9889b27c-98a7-4ff3-8552-9071d59307c1@linux.ibm.com> (raw)
In-Reply-To: <fa36ab5a04e10c6acb89583f646aad83df2b0b13.1761176219.git.balaton@eik.bme.hu>
On 10/23/25 05:36, BALATON Zoltan wrote:
> These are not needed any more now that VOF can handle it.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Harsh Prateek Bora <harshp@linux.ibm.com>
> ---
> hw/ppc/pegasos2.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
> index e15cf96427..73995624e5 100644
> --- a/hw/ppc/pegasos2.c
> +++ b/hw/ppc/pegasos2.c
> @@ -662,7 +662,6 @@ static void dt_isa(PCIBus *bus, PCIDevice *d, FDTInfo *fi)
> qemu_fdt_setprop_cell(fi->fdt, fi->path, "#size-cells", 1);
> qemu_fdt_setprop_cell(fi->fdt, fi->path, "#address-cells", 2);
> qemu_fdt_setprop_string(fi->fdt, fi->path, "device_type", "isa");
> - qemu_fdt_setprop_string(fi->fdt, fi->path, "name", "isa");
>
> /* additional devices */
> g_string_printf(name, "%s/lpt@i3bc", fi->path);
> @@ -677,7 +676,6 @@ static void dt_isa(PCIBus *bus, PCIDevice *d, FDTInfo *fi)
> cells[2] = cpu_to_be32(8);
> qemu_fdt_setprop(fi->fdt, name->str, "reg", cells, 3 * sizeof(cells[0]));
> qemu_fdt_setprop_string(fi->fdt, name->str, "device_type", "lpt");
> - qemu_fdt_setprop_string(fi->fdt, name->str, "name", "lpt");
>
> g_string_printf(name, "%s/fdc@i3f0", fi->path);
> qemu_fdt_add_subnode(fi->fdt, name->str);
> @@ -691,7 +689,6 @@ static void dt_isa(PCIBus *bus, PCIDevice *d, FDTInfo *fi)
> cells[2] = cpu_to_be32(8);
> qemu_fdt_setprop(fi->fdt, name->str, "reg", cells, 3 * sizeof(cells[0]));
> qemu_fdt_setprop_string(fi->fdt, name->str, "device_type", "fdc");
> - qemu_fdt_setprop_string(fi->fdt, name->str, "name", "fdc");
>
> g_string_printf(name, "%s/timer@i40", fi->path);
> qemu_fdt_add_subnode(fi->fdt, name->str);
> @@ -701,7 +698,6 @@ static void dt_isa(PCIBus *bus, PCIDevice *d, FDTInfo *fi)
> cells[2] = cpu_to_be32(8);
> qemu_fdt_setprop(fi->fdt, name->str, "reg", cells, 3 * sizeof(cells[0]));
> qemu_fdt_setprop_string(fi->fdt, name->str, "device_type", "timer");
> - qemu_fdt_setprop_string(fi->fdt, name->str, "name", "timer");
>
> g_string_printf(name, "%s/rtc@i70", fi->path);
> qemu_fdt_add_subnode(fi->fdt, name->str);
> @@ -716,7 +712,6 @@ static void dt_isa(PCIBus *bus, PCIDevice *d, FDTInfo *fi)
> cells[2] = cpu_to_be32(2);
> qemu_fdt_setprop(fi->fdt, name->str, "reg", cells, 3 * sizeof(cells[0]));
> qemu_fdt_setprop_string(fi->fdt, name->str, "device_type", "rtc");
> - qemu_fdt_setprop_string(fi->fdt, name->str, "name", "rtc");
>
> g_string_printf(name, "%s/keyboard@i60", fi->path);
> qemu_fdt_add_subnode(fi->fdt, name->str);
> @@ -729,7 +724,6 @@ static void dt_isa(PCIBus *bus, PCIDevice *d, FDTInfo *fi)
> cells[2] = cpu_to_be32(5);
> qemu_fdt_setprop(fi->fdt, name->str, "reg", cells, 3 * sizeof(cells[0]));
> qemu_fdt_setprop_string(fi->fdt, name->str, "device_type", "keyboard");
> - qemu_fdt_setprop_string(fi->fdt, name->str, "name", "keyboard");
>
> g_string_printf(name, "%s/8042@i60", fi->path);
> qemu_fdt_add_subnode(fi->fdt, name->str);
> @@ -743,7 +737,6 @@ static void dt_isa(PCIBus *bus, PCIDevice *d, FDTInfo *fi)
> cells[2] = cpu_to_be32(5);
> qemu_fdt_setprop(fi->fdt, name->str, "reg", cells, 3 * sizeof(cells[0]));
> qemu_fdt_setprop_string(fi->fdt, name->str, "device_type", "");
> - qemu_fdt_setprop_string(fi->fdt, name->str, "name", "8042");
>
> g_string_printf(name, "%s/serial@i2f8", fi->path);
> qemu_fdt_add_subnode(fi->fdt, name->str);
> @@ -757,7 +750,6 @@ static void dt_isa(PCIBus *bus, PCIDevice *d, FDTInfo *fi)
> cells[2] = cpu_to_be32(8);
> qemu_fdt_setprop(fi->fdt, name->str, "reg", cells, 3 * sizeof(cells[0]));
> qemu_fdt_setprop_string(fi->fdt, name->str, "device_type", "serial");
> - qemu_fdt_setprop_string(fi->fdt, name->str, "name", "serial");
>
> g_string_free(name, TRUE);
> }
> @@ -846,7 +838,6 @@ static void add_pci_device(PCIBus *bus, PCIDevice *d, void *opaque)
> j += 5;
> }
> qemu_fdt_setprop(fi->fdt, node->str, "reg", cells, j * sizeof(cells[0]));
> - qemu_fdt_setprop_string(fi->fdt, node->str, "name", name ?: pn);
> if (pci_get_byte(&d->config[PCI_INTERRUPT_PIN])) {
> qemu_fdt_setprop_cell(fi->fdt, node->str, "interrupts",
> pci_get_byte(&d->config[PCI_INTERRUPT_PIN]));
> @@ -916,7 +907,6 @@ static void *build_fdt(MachineState *machine, int *fdt_size)
> qemu_fdt_setprop_cell(fdt, "/pci@c0000000", "#size-cells", 2);
> qemu_fdt_setprop_cell(fdt, "/pci@c0000000", "#address-cells", 3);
> qemu_fdt_setprop_string(fdt, "/pci@c0000000", "device_type", "pci");
> - qemu_fdt_setprop_string(fdt, "/pci@c0000000", "name", "pci");
>
> fi.path = "/pci@c0000000";
> pci_bus = mv64361_get_pci_bus(pm->mv, 0);
> @@ -951,7 +941,6 @@ static void *build_fdt(MachineState *machine, int *fdt_size)
> qemu_fdt_setprop_cell(fdt, "/pci@80000000", "#size-cells", 2);
> qemu_fdt_setprop_cell(fdt, "/pci@80000000", "#address-cells", 3);
> qemu_fdt_setprop_string(fdt, "/pci@80000000", "device_type", "pci");
> - qemu_fdt_setprop_string(fdt, "/pci@80000000", "name", "pci");
>
> fi.path = "/pci@80000000";
> pci_bus = mv64361_get_pci_bus(pm->mv, 1);
> @@ -959,7 +948,6 @@ static void *build_fdt(MachineState *machine, int *fdt_size)
>
> qemu_fdt_add_subnode(fdt, "/failsafe");
> qemu_fdt_setprop_string(fdt, "/failsafe", "device_type", "serial");
> - qemu_fdt_setprop_string(fdt, "/failsafe", "name", "failsafe");
>
> qemu_fdt_add_subnode(fdt, "/rtas");
> qemu_fdt_setprop_cell(fdt, "/rtas", "system-reboot", RTAS_SYSTEM_REBOOT);
> @@ -989,14 +977,12 @@ static void *build_fdt(MachineState *machine, int *fdt_size)
> qemu_fdt_setprop_cell(fdt, "/rtas", "rtas-display-device", 0);
> qemu_fdt_setprop_cell(fdt, "/rtas", "rtas-size", 20);
> qemu_fdt_setprop_cell(fdt, "/rtas", "rtas-version", 1);
> - qemu_fdt_setprop_string(fdt, "/rtas", "name", "rtas");
>
> /* cpus */
> qemu_fdt_add_subnode(fdt, "/cpus");
> qemu_fdt_setprop_cell(fdt, "/cpus", "#cpus", 1);
> qemu_fdt_setprop_cell(fdt, "/cpus", "#address-cells", 1);
> qemu_fdt_setprop_cell(fdt, "/cpus", "#size-cells", 0);
> - qemu_fdt_setprop_string(fdt, "/cpus", "name", "cpus");
>
> /* FIXME Get CPU name from CPU object */
> const char *cp = "/cpus/PowerPC,G4";
> @@ -1048,7 +1034,6 @@ static void *build_fdt(MachineState *machine, int *fdt_size)
> cells[1] = 0;
> qemu_fdt_setprop(fdt, cp, "reg", cells, 2 * sizeof(cells[0]));
> qemu_fdt_setprop_string(fdt, cp, "device_type", "cpu");
> - qemu_fdt_setprop_string(fdt, cp, "name", strrchr(cp, '/') + 1);
>
> /* memory */
> qemu_fdt_add_subnode(fdt, "/memory@0");
> @@ -1056,7 +1041,6 @@ static void *build_fdt(MachineState *machine, int *fdt_size)
> cells[1] = cpu_to_be32(machine->ram_size);
> qemu_fdt_setprop(fdt, "/memory@0", "reg", cells, 2 * sizeof(cells[0]));
> qemu_fdt_setprop_string(fdt, "/memory@0", "device_type", "memory");
> - qemu_fdt_setprop_string(fdt, "/memory@0", "name", "memory");
>
> qemu_fdt_add_subnode(fdt, "/chosen");
> if (pm->initrd_addr && pm->initrd_size) {
> @@ -1067,7 +1051,6 @@ static void *build_fdt(MachineState *machine, int *fdt_size)
> }
> qemu_fdt_setprop_string(fdt, "/chosen", "bootargs",
> machine->kernel_cmdline ?: "");
> - qemu_fdt_setprop_string(fdt, "/chosen", "name", "chosen");
>
> qemu_fdt_add_subnode(fdt, "/openprom");
> qemu_fdt_setprop_string(fdt, "/openprom", "model", "Pegasos2,1.1");
next prev parent reply other threads:[~2025-10-23 4:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 0:06 [PATCH v4 00/12] Pegasos2 clean up and pegasos1 emulation BALATON Zoltan
2025-10-23 0:06 ` [PATCH v4 01/12] ppc/vof: Make nextprop behave more like Open Firmware BALATON Zoltan
2025-10-23 0:06 ` [PATCH v4 02/12] hw/ppc/pegasos2: Remove explicit name properties from device tree BALATON Zoltan
2025-10-23 4:55 ` Harsh Prateek Bora [this message]
2025-10-23 0:06 ` [PATCH v4 03/12] hw/ppc/pegasos2: Change device tree generation BALATON Zoltan
2025-10-23 0:06 ` [PATCH v4 04/12] hw/ppc/pegasos2: Remove fdt pointer from machine state BALATON Zoltan
2025-10-23 0:06 ` [PATCH v4 05/12] hw/ppc/pegasos2: Rename mv field in " BALATON Zoltan
2025-10-23 0:06 ` [PATCH v4 06/12] hw/ppc/pegasos2: Add south bridge pointer in the " BALATON Zoltan
2025-10-23 0:06 ` [PATCH v4 07/12] hw/ppc/pegasos2: Move PCI IRQ routing setup to a function BALATON Zoltan
2025-10-23 6:47 ` Philippe Mathieu-Daudé
2025-10-23 0:06 ` [PATCH v4 08/12] hw/ppc/pegasos2: Move hardware specific parts out of machine reset BALATON Zoltan
2025-10-23 6:46 ` Philippe Mathieu-Daudé
2025-10-23 8:45 ` Harsh Prateek Bora
2025-10-23 11:41 ` BALATON Zoltan
2025-10-23 12:58 ` BALATON Zoltan
2025-10-23 0:06 ` [PATCH v4 09/12] hw/ppc/pegasos2: Introduce abstract superclass BALATON Zoltan
2025-10-23 0:06 ` [PATCH v4 10/12] hw/ppc/pegasos2: Add bus frequency to machine state BALATON Zoltan
2025-10-23 6:36 ` Philippe Mathieu-Daudé
2025-10-23 11:05 ` BALATON Zoltan
2025-10-23 0:06 ` [PATCH v4 11/12] hw/ppc/pegasos2: Add Pegasos I emulation BALATON Zoltan
2025-10-23 6:54 ` Philippe Mathieu-Daudé
2025-10-23 13:14 ` BALATON Zoltan
2025-10-23 0:06 ` [PATCH v4 12/12] hw/ppc/pegasos2: Add VOF support for pegasos1 BALATON Zoltan
2025-10-23 6:49 ` Philippe Mathieu-Daudé
2025-10-23 11:39 ` [PATCH v4 00/12] Pegasos2 clean up and pegasos1 emulation Harsh Prateek Bora
2025-10-23 12:07 ` BALATON Zoltan
2025-10-23 12:15 ` BALATON Zoltan
2025-10-23 12:23 ` Harsh Prateek Bora
2025-10-23 12:29 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9889b27c-98a7-4ff3-8552-9071d59307c1@linux.ibm.com \
--to=harshpb@linux.ibm.com \
--cc=armbru@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).