From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Claudio Fontana <cfontana@suse.de>,
Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wenchao Wang <wenchao.wang@intel.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Paul Durrant" <paul@xen.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Jason Wang" <jasowang@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>,
"Dario Faggioli" <dfaggioli@suse.com>,
"Cameron Esfahani" <dirty@apple.com>,
haxm-team@intel.com, "Colin Xu" <colin.xu@intel.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Bruce Rogers" <brogers@suse.com>,
"Olaf Hering" <ohering@suse.de>,
"Emilio G . Cota" <cota@braap.org>
Subject: Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops
Date: Fri, 11 Dec 2020 19:54:54 +0100 [thread overview]
Message-ID: <988c68b8-e9bc-55f2-cb6e-2a7b3767c14f@redhat.com> (raw)
In-Reply-To: <2d76e092-14bf-f9dc-4703-811f7768f1a7@suse.de>
On 12/11/20 7:51 PM, Claudio Fontana wrote:
> On 12/11/20 7:26 PM, Philippe Mathieu-Daudé wrote:
>> On 12/11/20 7:22 PM, Richard Henderson wrote:
>>> On 12/11/20 12:15 PM, Claudio Fontana wrote:
>>>> Should I return this file to the original state (without the extra #includes that pretend it to be a standalone header file,
>>>> and call it
>>>>
>>>> tcg-cpu-ops.h.inc
>>>>
>>>> ?
>>>
>>> If this header can work with qemu/typedefs.h, then no, because the circularity
>>> has been resolved. Otherwise, yes.
>>
>> My editor got confused with TranslationBlock, which is why I asked
>> to include its declaration.
>>
>> Easier to forward-declare TranslationBlock in qemu/typedefs.h?
>>
>> Regards,
>>
>> Phil.
>>
>
> Hello Philippe,
>
> ok you propose to move the existing fwd declaration of TranslationBlock from cpu.h to qemu/typedefs.h .
I'll let that answer to Richard =)
>
> And what about #include "exec/memattrs.h"?
>
> I assume you propose to put struct MemTxAttrs there as a fwd declaration too,
>
> and this concludes our experiment here?
Well, there is no circular problem here, right?
(and Richard already reviewed patch #24 :P )
>
> Thanks,
>
> Claudio
>
next prev parent reply other threads:[~2020-12-11 19:48 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 8:31 [PATCH v11 00/25] i386 cleanup PART 1 Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 01/25] accel/tcg: split CpusAccel into three TCG variants Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 02/25] accel/tcg: split tcg_start_vcpu_thread Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 03/25] accel/tcg: rename tcg-cpus functions to match module name Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 04/25] i386: move kvm accel files into kvm/ Claudio Fontana
2020-12-11 16:08 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 05/25] i386: move whpx accel files into whpx/ Claudio Fontana
2020-12-11 16:09 ` Richard Henderson
2020-12-11 20:41 ` Eduardo Habkost
2020-12-12 9:24 ` Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 06/25] i386: move hax accel files into hax/ Claudio Fontana
2020-12-11 16:10 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 07/25] i386: hvf: remove stale MAINTAINERS entry for old hvf stubs Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 08/25] i386: move TCG accel files into tcg/ Claudio Fontana
2020-12-11 16:10 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 09/25] i386: move cpu dump out of helper.c into cpu-dump.c Claudio Fontana
2020-12-11 16:13 ` Richard Henderson
2020-12-11 17:21 ` Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 10/25] i386: move TCG cpu class initialization out of helper.c Claudio Fontana
2020-12-11 16:44 ` Richard Henderson
2020-12-11 17:31 ` Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 11/25] tcg: cpu_exec_{enter,exit} helpers Claudio Fontana
2020-12-11 16:45 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 12/25] tcg: make CPUClass.cpu_exec_* optional Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 13/25] tcg: Make CPUClass.debug_excp_handler optional Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 14/25] cpu: Remove unnecessary noop methods Claudio Fontana
2020-12-11 11:05 ` Philippe Mathieu-Daudé
2020-12-11 8:31 ` [PATCH v11 15/25] cpu: Introduce TCGCpuOperations struct Claudio Fontana
2020-12-11 16:55 ` Richard Henderson
2020-12-11 16:57 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 16/25] target/riscv: remove CONFIG_TCG, as it is always TCG Claudio Fontana
2020-12-11 16:56 ` Richard Henderson
2020-12-11 17:19 ` Claudio Fontana
2020-12-11 8:31 ` [PATCH v11 17/25] accel/tcg: split TCG-only code from cpu_exec_realizefn Claudio Fontana
2020-12-11 16:58 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops Claudio Fontana
2020-12-11 17:05 ` Richard Henderson
2020-12-11 17:10 ` Claudio Fontana
2020-12-11 17:11 ` Claudio Fontana
2020-12-11 17:28 ` Richard Henderson
2020-12-11 17:47 ` Claudio Fontana
2020-12-11 18:04 ` Richard Henderson
2020-12-11 18:15 ` Claudio Fontana
2020-12-11 18:22 ` Richard Henderson
2020-12-11 18:26 ` Philippe Mathieu-Daudé
2020-12-11 18:51 ` Claudio Fontana
2020-12-11 18:54 ` Philippe Mathieu-Daudé [this message]
2020-12-11 20:02 ` Eduardo Habkost
2020-12-12 10:00 ` Claudio Fontana
2020-12-12 11:41 ` Claudio Fontana
2020-12-14 21:04 ` Eduardo Habkost
2020-12-11 8:31 ` [PATCH v11 19/25] cpu: Move cpu_exec_* " Claudio Fontana
2020-12-11 17:30 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 20/25] cpu: Move tlb_fill " Claudio Fontana
2020-12-11 17:42 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 21/25] cpu: Move debug_excp_handler " Claudio Fontana
2020-12-11 17:44 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 22/25] target/arm: do not use cc->do_interrupt for KVM directly Claudio Fontana
2020-12-11 17:44 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 23/25] cpu: move cc->do_interrupt to tcg_ops Claudio Fontana
2020-12-11 17:46 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 24/25] cpu: move cc->transaction_failed " Claudio Fontana
2020-12-11 11:00 ` Philippe Mathieu-Daudé
2020-12-11 17:50 ` Richard Henderson
2020-12-11 8:31 ` [PATCH v11 25/25] cpu: move do_unaligned_access " Claudio Fontana
2020-12-11 11:01 ` Philippe Mathieu-Daudé
2020-12-11 17:58 ` Richard Henderson
2020-12-11 8:57 ` [PATCH v11 00/25] i386 cleanup PART 1 no-reply
2020-12-11 11:07 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=988c68b8-e9bc-55f2-cb6e-2a7b3767c14f@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=brogers@suse.com \
--cc=cfontana@suse.de \
--cc=colin.xu@intel.com \
--cc=cota@braap.org \
--cc=dfaggioli@suse.com \
--cc=dirty@apple.com \
--cc=ehabkost@redhat.com \
--cc=haxm-team@intel.com \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=mtosatti@redhat.com \
--cc=ohering@suse.de \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=wenchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).