From: Richard Henderson <richard.henderson@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/arm: Clean up arm_cpu_vq_map_next_smaller asserts
Date: Fri, 15 Nov 2019 18:45:51 +0100 [thread overview]
Message-ID: <989b6a18-9391-7351-74f5-9cd012f6aaa2@linaro.org> (raw)
In-Reply-To: <20191115160630.ofkre7rp5gszbpcd@kamzik.brq.redhat.com>
On 11/15/19 5:06 PM, Andrew Jones wrote:
>> bitnum = find_last_bit(cpu->sve_vq_map, vq - 1);
>> - return bitnum == vq - 1 ? 0 : bitnum + 1;
>> +
>> + /* We always have vq == 1 present in sve_vq_map. */
>
> This is true with TCG and 99.9999% likely to be true with KVM...
Eh? It's required by the spec that 128-bit vectors are always supported.
> Maybe we should just remove this function and put the
> find_last_bit() call and all input/output validation directly in
> sve_zcr_get_valid_len() ?
But that makes sense all on its own, so we don't do quite so much +1/-1 faffing
about.
r~
next prev parent reply other threads:[~2019-11-15 17:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 13:16 [PATCH] target/arm: Clean up arm_cpu_vq_map_next_smaller asserts Richard Henderson
2019-11-15 15:29 ` Alex Bennée
2019-11-15 16:06 ` Andrew Jones
2019-11-15 17:45 ` Richard Henderson [this message]
2019-11-18 7:51 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=989b6a18-9391-7351-74f5-9cd012f6aaa2@linaro.org \
--to=richard.henderson@linaro.org \
--cc=drjones@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).