From: Halil Pasic <pasic@linux.vnet.ibm.com>
To: "Collin L. Walling" <walling@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] s390-ccw: print carriage return with new lines
Date: Fri, 27 Oct 2017 17:55:49 +0200 [thread overview]
Message-ID: <989d044a-93fd-35b3-30f5-f210ca5dc44f@linux.vnet.ibm.com> (raw)
In-Reply-To: <2773f2f1-6b0f-855d-b51e-7e8d5ecd67ab@linux.vnet.ibm.com>
On 10/27/2017 05:47 PM, Collin L. Walling wrote:
>>
>
> I wanted to do the same, however str is void can cannot be indexed directly.
> We'd have to do some nasty casting first, so I figured having *p made things
> look cleaner.
I did not consider that, sorry. (One could rename p to str AFAIR to express
that we are actually scanning the parameter and that the local is just for
avoiding the cast). But I really think we should go with Alex's proposal.
Halil
prev parent reply other threads:[~2017-10-27 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 14:30 [Qemu-devel] [PATCH v3] s390-ccw: print carriage return with new lines Collin L. Walling
2017-10-27 14:46 ` Christian Borntraeger
2017-10-27 15:39 ` Halil Pasic
2017-10-27 15:47 ` Collin L. Walling
2017-10-27 15:55 ` Halil Pasic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=989d044a-93fd-35b3-30f5-f210ca5dc44f@linux.vnet.ibm.com \
--to=pasic@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=walling@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).