From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Claudio Fontana <cfontana@suse.de>, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: meson, NEED_CPU_H, CONFIG_TCG and tests/
Date: Fri, 19 Feb 2021 14:48:34 +0100 [thread overview]
Message-ID: <98a91214-1058-706c-1991-fc0b6fe7fb1c@redhat.com> (raw)
In-Reply-To: <7a465ccb-a2f9-9293-d0d4-dd4cc65bfb8d@suse.de>
On 2/19/21 2:17 PM, Claudio Fontana wrote:
> On 2/19/21 2:14 PM, Philippe Mathieu-Daudé wrote:
>> On 2/19/21 2:04 PM, Claudio Fontana wrote:
>>> Hi Paolo,
>>>
>>> currently we have use of CONFIG_TCG in tests/,
>>>
>>> but is that variable available at all in there?
>>>
>>> I have to adapt some qemu/tests/qtest/* to work also without tcg for ARM,
>>>
>>> but I think I am not seeing CONFIG_TCG filtering through, and I wonder whether all the checks in there are actually "wrong".
>>
>> Checking for ./configure definitions in tests is probably wrong,
>> it should be done via binary introspection (ask the binary if it
>> has the feature enabled).
>>
>
> How are we going to launch with the correct qemu options in qtest/bios-tables-test.c and qtest/boot-serial-tests.c ?
Isn't it what was recently discussed here?
https://www.mail-archive.com/qemu-devel@nongnu.org/msg779881.html
https://www.mail-archive.com/qemu-devel@nongnu.org/msg779868.html
>
> I mean I agree with your sentiment, but it does not solve the problem..
>
> Ciao,
>
> Claudio
>
next prev parent reply other threads:[~2021-02-19 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 13:04 meson, NEED_CPU_H, CONFIG_TCG and tests/ Claudio Fontana
2021-02-19 13:13 ` Claudio Fontana
2021-02-19 13:14 ` Philippe Mathieu-Daudé
2021-02-19 13:17 ` Claudio Fontana
2021-02-19 13:48 ` Philippe Mathieu-Daudé [this message]
2021-02-19 13:54 ` Claudio Fontana
2021-02-19 13:30 ` Thomas Huth
2021-02-19 16:04 ` Paolo Bonzini
2021-02-19 17:24 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98a91214-1058-706c-1991-fc0b6fe7fb1c@redhat.com \
--to=philmd@redhat.com \
--cc=cfontana@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).