qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Jag Raman <jag.raman@oracle.com>, qemu-devel <qemu-devel@nongnu.org>
Cc: "f4bug@amsat.org" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: Help adding package to gitlab runners
Date: Mon, 13 Sep 2021 07:38:27 +0200	[thread overview]
Message-ID: <98c9bdc9-dceb-1444-abf4-64b919e642d4@redhat.com> (raw)
In-Reply-To: <2CFBCC64-910E-43DF-8A57-8F20671DD7D4@oracle.com>

On 13/09/2021 03.14, Jag Raman wrote:
> Hi,
> 
> I'm wondering about the best way to install a dependency package on
> GitLab runners.
>
> I'm adding libvfio-user [1] as a submodule to QEMU. libvfio-user depends
> on the availability of the "json-c" package. As such, we need to install this
> package to build the library as part of QEMU.
> 
> I saw that we could add a "before_script" section to the jobs in
> ".gitlab-ci.d/buildtest.yml" - this section could have commands to install the
> "json-c" package before running the job. However, this option is specific to
> a job.
> 
> I wonder if there is a way to do this for all jobs. I saw that
> "scripts/ci/setup/build-environment.yml" has a list of packages needed to
> build QEMU - this one seems Ubuntu-specific.
> 
> How long does it take for changes made to this file (build-environment.yml)
> to propagate? Are all QEMU's GitLab runners Ubuntu-based?

No, this file (build-environment.yml) is only used to prepare the non-shared 
custom runners (see .gitlab-ci.d/custom-runners.yml), which only run on the 
staging branch of the qemu-project (or if you supply your own non-x86 runners).

I think in your case, you likely want to modify the shared runners instead. 
For this, we're using containers that are prepared in the first two stages 
of the CI pipelines. You can modify the container definitions in 
tests/docker/dockerfiles/. Once you add your package there, it should get 
used directly the next time you push a branch with the modification to gitlab.

  HTH,
   Thomas



  reply	other threads:[~2021-09-13  5:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13  1:14 Help adding package to gitlab runners Jag Raman
2021-09-13  5:38 ` Thomas Huth [this message]
2021-09-13 13:49   ` Jag Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98c9bdc9-dceb-1444-abf4-64b919e642d4@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=jag.raman@oracle.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).