From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block
Date: Fri, 3 May 2019 17:02:11 +0200 [thread overview]
Message-ID: <98cd84db-2aed-4aa1-1f2d-eaa7ac63b72b@redhat.com> (raw)
In-Reply-To: <20190503143904.31211-1-alex.bennee@linaro.org>
On 03/05/2019 16.39, Alex Bennée wrote:
> This attempts to clean-up the output to better match the output of the
> rest of the QEMU check system. This includes:
>
> - formatting as " TEST iotest: nnn"
> - calculating time diff at the end
> - only dumping config on failure
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/qemu-iotests/check | 71 +++++++++++++++++++---------------------
> 1 file changed, 34 insertions(+), 37 deletions(-)
Thanks for tackling this! The output now looks nicer indeed if you run
"make check-qtest check-block -j8". However, if you add a "V=1" at the
end of the command line, the outputs look quite different again...
That's why I thought that having a TAP mode for the check script could
be a good idea, too. Then we could pipe the output through the
tap-driver.pl script, too, so we get uniform output for all tests...?
Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
"open list:Block layer core" <qemu-block@nongnu.org>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block
Date: Fri, 3 May 2019 17:02:11 +0200 [thread overview]
Message-ID: <98cd84db-2aed-4aa1-1f2d-eaa7ac63b72b@redhat.com> (raw)
Message-ID: <20190503150211.2BC9B3XKCseqlZPJ3cPde80nuo9IAGAadlbnZ_wVFy8@z> (raw)
In-Reply-To: <20190503143904.31211-1-alex.bennee@linaro.org>
On 03/05/2019 16.39, Alex Bennée wrote:
> This attempts to clean-up the output to better match the output of the
> rest of the QEMU check system. This includes:
>
> - formatting as " TEST iotest: nnn"
> - calculating time diff at the end
> - only dumping config on failure
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/qemu-iotests/check | 71 +++++++++++++++++++---------------------
> 1 file changed, 34 insertions(+), 37 deletions(-)
Thanks for tackling this! The output now looks nicer indeed if you run
"make check-qtest check-block -j8". However, if you add a "V=1" at the
end of the command line, the outputs look quite different again...
That's why I thought that having a TAP mode for the check script could
be a good idea, too. Then we could pipe the output through the
tap-driver.pl script, too, so we get uniform output for all tests...?
Thomas
next prev parent reply other threads:[~2019-05-03 15:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 14:39 [Qemu-devel] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block Alex Bennée
2019-05-03 14:39 ` Alex Bennée
2019-05-03 15:02 ` Thomas Huth [this message]
2019-05-03 15:02 ` Thomas Huth
2019-05-03 16:15 ` Alex Bennée
2019-05-03 16:15 ` Alex Bennée
2019-05-05 15:54 ` Thomas Huth
2019-05-05 15:54 ` Thomas Huth
2019-05-06 17:14 ` Vladimir Sementsov-Ogievskiy
2019-05-06 18:53 ` Alex Bennée
2019-05-06 17:32 ` Eric Blake
2019-05-06 19:02 ` Alex Bennée
2019-05-05 16:01 ` Thomas Huth
2019-05-05 16:01 ` Thomas Huth
2019-05-07 8:10 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98cd84db-2aed-4aa1-1f2d-eaa7ac63b72b@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).