Re: [PATCH for-8.1] accel/tcg: Zero-pad PC in TCG CPU exec trace lines

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 11/7/23 18:54, Peter Maydell wrote:
> In commit f0a08b0913befbd we changed the type of the PC from
> target_ulong to vaddr.  In doing so we inadvertently dropped the
> zero-padding on the PC in trace lines (the second item inside the []
> in these lines).  They used to look like this on AArch64, for
> instance:
> 
> Trace 0: 0x7f2260000100 [00000000/0000000040000000/00000061/ff200000]
> 
> and now they look like this:
> Trace 0: 0x7f4f50000100 [00000000/40000000/00000061/ff200000]
> 
> and if the PC happens to be somewhere low like 0x5000
> then the field is shown as /5000/.
> 
> This is because TARGET_FMT_lx is a "%08x" or "%016x" specifier,
> depending on TARGET_LONG_SIZE, whereas VADDR_PRIx is just PRIx64
> with no width specifier.
> 
> Restore the zero-padding by adding an 016 width specifier to
> this tracing and a couple of others that were similarly recently
> changed to use VADDR_PRIx without a width specifier.
> 
> We can't unfortunately restore the "32-bit guests are padded to
> 8 hex digits and 64-bit guests to 16 hex digits" behaviour so
> easily.
> 
> Fixes: f0a08b0913befbd ("accel/tcg/cpu-exec.c: Widen pc to vaddr")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I have a workflow that parses log files to get the executed
> PC values; I don't suppose I'm the only one doing that...
> ---
>   accel/tcg/cpu-exec.c      | 4 ++--
>   accel/tcg/translate-all.c | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>