qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Alistair Francis" <alistair.francis@xilinx.com>,
	qemu-ppc <qemu-ppc@nongnu.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH 4/5] configs: Add a CONFIG_UNIMP switch for the "unimplemented-device"
Date: Fri, 19 Oct 2018 17:59:34 +0200	[thread overview]
Message-ID: <98df614b-e432-5a18-34f3-b2275ba9af93@redhat.com> (raw)
In-Reply-To: <CAFEAcA9Pb5Dw9zu5_esYwor+MEmUJ=f4ZZqifui9qyJdKWbTiQ@mail.gmail.com>

On 19/10/2018 16:43, Peter Maydell wrote:
> I think if we want to support this for downstreams we need
> to look at something better than the default-configs/
> mechanism for it. (Perhaps the kconfig-alike Paolo mentioned
> in a previous thread?)

True, but having more CONFIG_* symbols does not complicate the switch to
a system like that one.

> My dividing line for "should something go in a specific
> architecture's default-configs/ list" is "is this an SoC
> or real piece of hardware that is naturally limited to
> one or a few SoCs".

I tend to agree, but I'd rather have a separate CONFIG_* symbol as soon
as two different *targets* (aka default-configs/*.mak files) use a
device.  So the SPARC change that you mention would actually be a good
reason to introduce CONFIG_UNIMP, for example.

Paolo

  reply	other threads:[~2018-10-19 16:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19 13:14 [Qemu-devel] [PATCH 0/5] Add more CONFIG switches to make the build more modular Thomas Huth
2018-10-19 13:14 ` [Qemu-devel] [PATCH 1/5] configs: Add a CONFIG_OR_IRQ switch for the or-irq device Thomas Huth
2018-10-19 13:58   ` Peter Maydell
2018-10-19 13:14 ` [Qemu-devel] [PATCH 2/5] configs: Add a CONFIG_SPLIT_IRQ switch for the split-irq device Thomas Huth
2018-10-19 14:44   ` Peter Maydell
2018-10-19 13:14 ` [Qemu-devel] [PATCH 3/5] configs: Add a CONFIG_REGISTER switch for the "register" device Thomas Huth
2018-10-19 14:44   ` Peter Maydell
2018-10-19 13:14 ` [Qemu-devel] [PATCH 4/5] configs: Add a CONFIG_UNIMP switch for the "unimplemented-device" Thomas Huth
2018-10-19 13:57   ` Peter Maydell
2018-10-19 14:40     ` Thomas Huth
2018-10-19 14:43       ` Peter Maydell
2018-10-19 15:59         ` Paolo Bonzini [this message]
2018-10-19 16:25       ` Philippe Mathieu-Daudé
2018-10-19 16:44         ` Paolo Bonzini
2018-10-19 16:54           ` Peter Maydell
2018-10-20 19:57             ` Paolo Bonzini
2018-10-19 13:14 ` [Qemu-devel] [PATCH 5/5] configs: Add a CONFIG_SMC37C669 switch for the "smc37c669-superio" device Thomas Huth
2018-10-19 14:46   ` Peter Maydell
2018-10-19 16:35     ` Philippe Mathieu-Daudé
2018-10-19 16:38       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98df614b-e432-5a18-34f3-b2275ba9af93@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alistair.francis@xilinx.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).