From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] target/arm: Fix handling of LDAPR/STLR with negative offset
Date: Tue, 9 Jul 2024 08:45:27 -0700 [thread overview]
Message-ID: <98e73d45-4217-4e75-8440-13a4ceb9042f@linaro.org> (raw)
In-Reply-To: <448e03c7-9bf8-48f5-b172-36bb06ec1139@linaro.org>
On 7/9/24 07:11, Philippe Mathieu-Daudé wrote:
> BTW I noted some instr formats use 'uimm*' for unsigned immediate.
> Maybe we could recommend/enforce that, having 'imm*' always signed.
With Arm, especially with load/store, some insns have unsigned fields and some have signed
fields, but for implementation purposes we need to use the same argument set. Therefore
we cannot mix names like this.
This naming convention works better with more regular encodings such as riscv or loongarch.
r~
next prev parent reply other threads:[~2024-07-09 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 13:45 [PATCH 0/2] target/arm: two LDAPR/STLR fixes Peter Maydell
2024-07-09 13:45 ` [PATCH 1/2] target/arm: Fix handling of LDAPR/STLR with negative offset Peter Maydell
2024-07-09 13:52 ` Philippe Mathieu-Daudé
2024-07-09 14:11 ` Philippe Mathieu-Daudé
2024-07-09 15:45 ` Richard Henderson [this message]
2024-07-09 15:45 ` Richard Henderson
2024-07-09 13:45 ` [PATCH 2/2] target/arm: LDAPR should honour SCTLR_ELx.nAA Peter Maydell
2024-07-09 15:51 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98e73d45-4217-4e75-8440-13a4ceb9042f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).