From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: philmd@redhat.com
Subject: Re: [PATCH 3/3] trace: do not include TCG helper tracepoints in no-TCG builds
Date: Wed, 16 Dec 2020 09:13:32 -0600 [thread overview]
Message-ID: <98e787e4-884b-61c5-bf52-b041f57747c3@linaro.org> (raw)
In-Reply-To: <20201216135529.265165-4-pbonzini@redhat.com>
On 12/16/20 7:55 AM, Paolo Bonzini wrote:
> diff --git a/trace/meson.build b/trace/meson.build
> index 3fa760f568..012d0dbceb 100644
> --- a/trace/meson.build
> +++ b/trace/meson.build
> @@ -71,7 +71,7 @@ foreach d : [
> input: meson.project_source_root() / 'trace-events',
> command: [ tracetool, '--group=root', '--format=@0@'.format(d[1]), '@INPUT@' ],
> capture: true)
> - specific_ss.add(gen)
> + specific_ss.add(when: 'CONFIG_TCG', if_true: gen)
> endforeach
Sure, unless it makes more sense to conditionalize the entire loop, so that
those targets aren't even created?
Acked-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-12-16 15:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 13:55 [PATCH 0/3] Cleanup includes for no-TCG builds Paolo Bonzini
2020-12-16 13:55 ` [PATCH 1/3] remove TCG includes from common code Paolo Bonzini
2020-12-16 15:10 ` Richard Henderson
2020-12-16 15:36 ` Philippe Mathieu-Daudé
2020-12-16 13:55 ` [PATCH 2/3] move icache flush out of tcg.h Paolo Bonzini
2020-12-16 14:52 ` Richard Henderson
2020-12-16 14:57 ` Paolo Bonzini
2020-12-16 13:55 ` [PATCH 3/3] trace: do not include TCG helper tracepoints in no-TCG builds Paolo Bonzini
2020-12-16 15:13 ` Richard Henderson [this message]
2020-12-16 15:22 ` Paolo Bonzini
2020-12-16 15:25 ` Richard Henderson
2020-12-16 15:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98e787e4-884b-61c5-bf52-b041f57747c3@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).