From: Thomas Huth <thuth@redhat.com>
To: Nicholas Piggin <npiggin@gmail.com>, Fabiano Rosas <farosas@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns
Date: Mon, 27 May 2024 09:32:56 +0200 [thread overview]
Message-ID: <98ec8131-2b81-4e40-abfc-d5fbcf1b41d8@redhat.com> (raw)
In-Reply-To: <20240525031330.196609-2-npiggin@gmail.com>
On 25/05/2024 05.13, Nicholas Piggin wrote:
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> tests/qtest/migration-test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index b7e3406471..c13535c37d 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -21,6 +21,7 @@
> #include "chardev/char.h"
> #include "crypto/tlscredspsk.h"
> #include "qapi/qmp/qlist.h"
> +#include "libqos/libqos-spapr.h"
It's a little bit unfortunate to include a libqos header in a non-qos test
... so in case you respin, maybe add a comment at the end of the line like:
/* just for PSERIES_DEFAULT_CAPABILITIES */
?
> #include "migration-helpers.h"
> #include "tests/migration/migration-test.h"
> @@ -742,7 +743,8 @@ static int test_migrate_start(QTestState **from, QTestState **to,
> "until'", end_address, start_address);
> machine_alias = "pseries";
> machine_opts = "vsmt=8";
> - arch_opts = g_strdup("-nodefaults");
> + arch_opts = g_strdup_printf("-nodefaults "
> + "-machine " PSERIES_DEFAULT_CAPABILITIES);
> } else if (strcmp(arch, "aarch64") == 0) {
> memory_size = "150M";
> machine_alias = "virt";
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-05-27 7:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-25 3:13 [PATCH 0/3] tests/qtest/migration-test: Improve and enable on ppc64 Nicholas Piggin
2024-05-25 3:13 ` [PATCH 1/3] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns Nicholas Piggin
2024-05-27 7:32 ` Thomas Huth [this message]
2024-05-27 11:26 ` Nicholas Piggin
2024-05-27 11:37 ` Thomas Huth
2024-05-25 3:13 ` [PATCH 2/3] tests/qtest/migration-test: Enable on ppc64 Nicholas Piggin
2024-05-27 7:35 ` Thomas Huth
2024-05-27 11:27 ` Nicholas Piggin
2024-05-25 3:13 ` [PATCH 3/3] tests/qtest/migration-test: Use custom asm bios for ppc64 Nicholas Piggin
2024-05-27 13:01 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98ec8131-2b81-4e40-abfc-d5fbcf1b41d8@redhat.com \
--to=thuth@redhat.com \
--cc=farosas@suse.de \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).