Re: [PATCH-for-10.1 v3 14/19] tcg: Remove the TCG_GUEST_DEFAULT_MO definition globally

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

Hi Richard,

On 4/4/25 00:04, Philippe Mathieu-Daudé wrote:
> By directly using TCGCPUOps::guest_default_memory_order,
> we don't need the TCG_GUEST_DEFAULT_MO definition anymore.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Anton Johansson <anjo@rev.ng>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   docs/devel/multi-thread-tcg.rst |  4 ++--
>   target/alpha/cpu-param.h        |  3 ---
>   target/arm/cpu-param.h          |  3 ---
>   target/avr/cpu-param.h          |  2 --
>   target/hexagon/cpu-param.h      |  3 ---
>   target/hppa/cpu-param.h         |  8 --------
>   target/i386/cpu-param.h         |  3 ---
>   target/loongarch/cpu-param.h    |  2 --
>   target/m68k/cpu-param.h         |  3 ---
>   target/microblaze/cpu-param.h   |  3 ---
>   target/mips/cpu-param.h         |  2 --
>   target/openrisc/cpu-param.h     |  2 --
>   target/ppc/cpu-param.h          |  2 --
>   target/riscv/cpu-param.h        |  2 --
>   target/rx/cpu-param.h           |  3 ---
>   target/s390x/cpu-param.h        |  6 ------
>   target/sh4/cpu-param.h          |  3 ---
>   target/sparc/cpu-param.h        | 23 -----------------------
>   target/tricore/cpu-param.h      |  3 ---
>   target/xtensa/cpu-param.h       |  3 ---
>   target/alpha/cpu.c              |  3 ++-
>   target/arm/cpu.c                |  3 ++-
>   target/arm/tcg/cpu-v7m.c        |  3 ++-
>   target/avr/cpu.c                |  2 +-
>   target/hexagon/cpu.c            |  3 ++-
>   target/hppa/cpu.c               |  8 +++++++-
>   target/i386/tcg/tcg-cpu.c       |  5 ++++-
>   target/loongarch/cpu.c          |  2 +-
>   target/m68k/cpu.c               |  3 ++-
>   target/microblaze/cpu.c         |  3 ++-
>   target/mips/cpu.c               |  2 +-
>   target/openrisc/cpu.c           |  2 +-
>   target/ppc/cpu_init.c           |  2 +-
>   target/riscv/tcg/tcg-cpu.c      |  2 +-
>   target/rx/cpu.c                 |  3 ++-
>   target/s390x/cpu.c              |  6 +++++-
>   target/sh4/cpu.c                |  3 ++-
>   target/sparc/cpu.c              | 23 ++++++++++++++++++++++-
>   target/tricore/cpu.c            |  3 ++-
>   target/xtensa/cpu.c             |  3 ++-
>   40 files changed, 66 insertions(+), 101 deletions(-)

I forgot this:

-- >8 --
diff --git a/include/exec/poison.h b/include/exec/poison.h
index bc422719d80..413dfd16f24 100644
--- a/include/exec/poison.h
+++ b/include/exec/poison.h
@@ -38,3 +38,2 @@
  #pragma GCC poison TARGET_BIG_ENDIAN
-#pragma GCC poison TCG_GUEST_DEFAULT_MO
  #pragma GCC poison TARGET_HAS_PRECISE_SMC

---

Could you squash it in your tcg-next tree?

Thanks,

Phil.