From: Paolo Bonzini <pbonzini@redhat.com>
To: "Xu, Anthony" <anthony.xu@intel.com>
Cc: "Zhong, Yang" <yang.zhong@intel.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Peng, Chao P" <chao.p.peng@intel.com>
Subject: Re: [Qemu-devel] [PATCH v1 2/2] reduce qemu's heap Rss size from 12252kB to 2752KB
Date: Tue, 14 Mar 2017 11:14:51 +0100 [thread overview]
Message-ID: <991a0f3d-5e1f-d17c-a8f3-a42c02ac2f17@redhat.com> (raw)
In-Reply-To: <4712D8F4B26E034E80552F30A67BE0B1A13045@ORSMSX112.amr.corp.intel.com>
On 14/03/2017 06:14, Xu, Anthony wrote:
> Below functions are registered in RCU thread
> address_space_dispatch_free,
> do_address_space_destroy
> flatview_unref
> reclaim_ramblock,
> qht_map_destroy,
> migration_bitmap_free
>
> first three are address space related, should work without global lock per above analysis.
> The rest are very simple, seems doesn't need global lock.
flatview_unref can call object_unref and thus reach:
- all QOM instance_finalize callbacks
- all QOM property release callbacks
In turn, of QOM property release callbacks the more important ones are
release_drive (which calls blockdev_auto_del and blk_detach_dev) and
release_chr (which calls qemu_chr_fe_deinit).
Your patch is incorrect, sorry. If it were that simple, it would have
been done already...
Paolo
next prev parent reply other threads:[~2017-03-14 10:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 15:14 [Qemu-devel] [PATCH v1 1/2] reduce qemu's heap Rss size from 12252kB to 2752KB Yang Zhong
2017-03-10 8:41 ` Paolo Bonzini
2017-03-10 16:05 ` Xu, Anthony
2017-03-10 16:07 ` Paolo Bonzini
2017-03-10 19:30 ` Xu, Anthony
2017-03-11 17:02 ` Paolo Bonzini
2017-03-10 15:14 ` [Qemu-devel] [PATCH v1 2/2] " Yang Zhong
2017-03-10 9:14 ` Paolo Bonzini
2017-03-10 17:40 ` Xu, Anthony
2017-03-11 17:04 ` Paolo Bonzini
2017-03-14 5:14 ` Xu, Anthony
2017-03-14 10:14 ` Paolo Bonzini [this message]
2017-03-14 21:23 ` Xu, Anthony
2017-03-15 8:36 ` Paolo Bonzini
2017-03-15 19:05 ` Xu, Anthony
2017-03-15 20:21 ` Paolo Bonzini
2017-03-16 2:47 ` Zhong, Yang
2017-03-16 20:02 ` Xu, Anthony
2017-03-22 11:46 ` Paolo Bonzini
2017-03-22 18:26 ` Xu, Anthony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=991a0f3d-5e1f-d17c-a8f3-a42c02ac2f17@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony.xu@intel.com \
--cc=chao.p.peng@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).