From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: philmd@linaro.org
Subject: Re: [PATCH v2 18/18] stubs: move monitor_fdsets_cleanup with other fdset stubs
Date: Mon, 8 Apr 2024 07:02:47 -1000 [thread overview]
Message-ID: <991a55ad-663c-4bcf-ba3d-4a3f7ebc49ae@linaro.org> (raw)
In-Reply-To: <20240408155330.522792-19-pbonzini@redhat.com>
On 4/8/24 05:53, Paolo Bonzini wrote:
> Even though monitor_get_fd() has to remain separate because it is mocked by
> tests/unit/test-util-sockets, monitor_fdsets_cleanup() is logically part
> of the stubs for monitor/fds.c, so move it there.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> stubs/fdset.c | 6 ++++++
> stubs/monitor-internal.c | 5 -----
> 2 files changed, 6 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2024-04-08 17:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 15:53 [PATCH v2 0/7] buildsys: Start shrinking qemu-user build process Paolo Bonzini
2024-04-08 15:53 ` [PATCH v2 01/18] meson: do not link pixman automatically into all targets Paolo Bonzini
2024-04-08 16:41 ` Richard Henderson
2024-04-08 15:53 ` [PATCH v2 02/18] tests: only build plugins if TCG is enabled Paolo Bonzini
2024-04-08 15:54 ` Philippe Mathieu-Daudé
2024-04-08 17:03 ` Richard Henderson
2024-04-08 15:53 ` [PATCH v2 03/18] ebpf: Restrict to system emulation Paolo Bonzini
2024-04-08 15:53 ` [PATCH v2 04/18] tests/unit: match some unit tests to corresponding feature switches Paolo Bonzini
2024-04-08 16:42 ` Richard Henderson
2024-04-08 15:53 ` [PATCH v2 05/18] yank: only build if needed Paolo Bonzini
2024-04-08 15:55 ` Philippe Mathieu-Daudé
2024-04-08 16:42 ` Richard Henderson
2024-04-08 15:53 ` [PATCH v2 06/18] util/qemu-config: Extract QMP commands to qemu-config-qmp.c Paolo Bonzini
2024-04-08 15:53 ` [PATCH v2 07/18] hw/core: Move system emulation files to system_ss Paolo Bonzini
2024-04-08 16:45 ` Richard Henderson
2024-04-08 15:53 ` [PATCH v2 08/18] hw: Include minimal source set in user emulation build Paolo Bonzini
2024-04-08 15:53 ` [PATCH v2 09/18] stubs: remove obsolete stubs Paolo Bonzini
2024-04-08 16:46 ` Richard Henderson
2024-04-08 15:53 ` [PATCH v2 10/18] hw/usb: move stubs out of stubs/ Paolo Bonzini
2024-04-08 15:59 ` Philippe Mathieu-Daudé
2024-04-08 16:47 ` Richard Henderson
2024-04-08 15:53 ` [PATCH v2 11/18] hw/virtio: " Paolo Bonzini
2024-04-08 16:47 ` Richard Henderson
2024-04-08 15:53 ` [PATCH v2 12/18] semihosting: " Paolo Bonzini
2024-04-08 15:53 ` [PATCH v2 13/18] ramfb: " Paolo Bonzini
2024-04-08 15:59 ` Philippe Mathieu-Daudé
2024-04-08 16:49 ` Richard Henderson
2024-04-08 16:50 ` Richard Henderson
2024-04-08 15:53 ` [PATCH v2 14/18] memory-device: " Paolo Bonzini
2024-04-08 16:50 ` Richard Henderson
2024-04-08 18:17 ` Philippe Mathieu-Daudé
2024-04-08 15:53 ` [PATCH v2 15/18] colo: " Paolo Bonzini
2024-04-08 15:53 ` [PATCH v2 16/18] stubs: split record/replay stubs further Paolo Bonzini
2024-04-08 16:59 ` Richard Henderson
2024-04-08 17:14 ` Paolo Bonzini
2024-04-08 15:53 ` [PATCH v2 17/18] stubs: include stubs only if needed Paolo Bonzini
2024-04-08 15:53 ` [PATCH v2 18/18] stubs: move monitor_fdsets_cleanup with other fdset stubs Paolo Bonzini
2024-04-08 17:02 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=991a55ad-663c-4bcf-ba3d-4a3f7ebc49ae@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).