qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Sebastian Herbszt" <herbszt@gmx.de>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Work around stdio redirection by SDL on Windows
Date: Mon, 10 Aug 2009 00:00:08 +0200	[thread overview]
Message-ID: <995EB2524B354E00A17BA598EF23C718@FSCPC> (raw)
In-Reply-To: <5b31733c0908090526w6594523dvff8b6cbce3f80277@mail.gmail.com>

Filip Navara wrote:
>> Sebastian Herbszt wrote:
>> --- v0.11.0-rc0-201-gd9c3231/vl.c.orig Sun Aug 9 11:52:47 2009
>> +++ v0.11.0-rc0-201-gd9c3231/vl.c Sun Aug 9 11:58:59 2009
>> @@ -4873,6 +4873,12 @@
>> CPUState *env;
>> int show_vnc_port = 0;
>>
>> +/* Work around stdio redirection by SDL on Windows */
>> +#if defined (CONFIG_SDL) && defined (_WIN32)
>> + freopen("CON", "wb", stdout);
>> + freopen("CON", "wb", stderr);
>> +#endif
>> +
>
> That will not work in RXVT, SSH consoles and for pipes unfortunately
> :-/ Also it won't respect the redirections specified on command line,
> which is something I often use, therefore I object to this patch. It's
> better to use SDL compiled with the --enable-stdio-redirect=no option.

Too bad this work around is a no go. At least for me it's good enough to
make qemu usable again.

I hope the need for a custom SDL will at least get properly documented since
this is a big regression for Windows users.

- Sebastian

      reply	other threads:[~2009-08-09 22:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-09 12:06 [Qemu-devel] [PATCH] Work around stdio redirection by SDL on Windows Sebastian Herbszt
2009-08-09 12:26 ` [Qemu-devel] " Filip Navara
2009-08-09 22:00   ` Sebastian Herbszt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=995EB2524B354E00A17BA598EF23C718@FSCPC \
    --to=herbszt@gmx.de \
    --cc=filip.navara@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).