From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/arm: Implement FEAT_IDST
Date: Mon, 9 May 2022 14:24:52 -0700 [thread overview]
Message-ID: <995ec3be-1a3f-4f51-35ac-bad866d75e51@linaro.org> (raw)
In-Reply-To: <20220509155457.3560724-1-peter.maydell@linaro.org>
On 5/9/22 10:54, Peter Maydell wrote:
> @@ -841,6 +841,7 @@ static void aarch64_max_initfn(Object *obj)
> t = FIELD_DP64(t, ID_AA64MMFR2, VARANGE, 1); /* FEAT_LVA */
> t = FIELD_DP64(t, ID_AA64MMFR2, TTL, 1); /* FEAT_TTL */
> t = FIELD_DP64(t, ID_AA64MMFR2, BBM, 2); /* FEAT_BBM at level 2 */
> + t = FIELD_DP64(t, ID_AA64MMFR2, IDS, 1); /* FEAT_IDST */
Ideally this should be sorted before TTL, by bit order.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2022-05-09 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 15:54 [PATCH] target/arm: Implement FEAT_IDST Peter Maydell
2022-05-09 21:24 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=995ec3be-1a3f-4f51-35ac-bad866d75e51@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).