From: Ulrich Obergfell <uobergfe@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org,
kvm <kvm@vger.kernel.org>,
gcosta@redhat.com
Subject: [Qemu-devel] Re: [PATCH 3/3] alleviate time drift with HPET periodic timers
Date: Tue, 22 Mar 2011 06:03:20 -0400 (EDT) [thread overview]
Message-ID: <996058219.455940.1300788200730.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <4D847B0C.3030400@web.de>
>> Part 3 of the patch implements the following options for the
>> 'configure' script.
>>
>> --disable-hpet-driftfix
>> --enable-hpet-driftfix
>
> I see no benefit in this configurability. Just make the driftfix
> unconditionally available, runtime-disabled by default for now until it
> matured and there is no downside in enabling it all the time.
Many Thanks Jan,
I enclosed the code in '#ifdef CONFIG_HPET_DRIFTFIX ... #endif'
so that it can be easily identified (and removed if the generic API
would be implemented some day). Since the ifdef's are already there
I added the configuration option for convenience. As you don't see
any benefit in this option, I can remove that part of the patch.
However, I'd suggest to keep the ifdef's and do the following:
- Rename to '#ifdef HPET_DRIFTFIX ... #endif' to make it clear that
this is not controlled via a configuration option.
- Add '#define HPET_DRIFTFIX' to hw/hpet_emul.h.
Do you agree ?
Regards,
Uli
next prev parent reply other threads:[~2011-03-22 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1225303441.421235.1300462107604.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2011-03-18 15:55 ` [Qemu-devel] [PATCH 3/3] alleviate time drift with HPET periodic timers Ulrich Obergfell
2011-03-19 9:44 ` [Qemu-devel] " Jan Kiszka
2011-03-22 10:03 ` Ulrich Obergfell [this message]
2011-03-22 10:08 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=996058219.455940.1300788200730.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com \
--to=uobergfe@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=gcosta@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).