From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33974 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q1yR9-0003Iq-KA
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 06:03:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <uobergfe@redhat.com>) id 1Q1yR7-0002uY-Q5
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 06:03:39 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:54189)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <uobergfe@redhat.com>) id 1Q1yR7-0002uS-E6
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 06:03:37 -0400
Date: Tue, 22 Mar 2011 06:03:20 -0400 (EDT)
From: Ulrich Obergfell <uobergfe@redhat.com>
Message-ID: <996058219.455940.1300788200730.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
In-Reply-To: <4D847B0C.3030400@web.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/3] alleviate time drift with HPET
	periodic timers
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm <kvm@vger.kernel.org>, gcosta@redhat.com


>> Part 3 of the patch implements the following options for the
>> 'configure' script.
>>
>> --disable-hpet-driftfix
>> --enable-hpet-driftfix
> 
> I see no benefit in this configurability. Just make the driftfix
> unconditionally available, runtime-disabled by default for now until it
> matured and there is no downside in enabling it all the time.


Many Thanks Jan,

I enclosed the code in '#ifdef CONFIG_HPET_DRIFTFIX ... #endif'
so that it can be easily identified (and removed if the generic API
would be implemented some day). Since the ifdef's are already there
I added the configuration option for convenience. As you don't see
any benefit in this option, I can remove that part of the patch.
However, I'd suggest to keep the ifdef's and do the following:

- Rename to '#ifdef HPET_DRIFTFIX ... #endif' to make it clear that
  this is not controlled via a configuration option.

- Add '#define HPET_DRIFTFIX' to hw/hpet_emul.h.

Do you agree ?


Regards,

Uli