From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35396)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1T3kzb-0001VB-5M
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 05:43:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1T3kzV-0005nM-2J
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 05:43:23 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:47854)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1T3kzU-0005n7-Ql
	for qemu-devel@nongnu.org; Tue, 21 Aug 2012 05:43:16 -0400
Date: Tue, 21 Aug 2012 05:43:14 -0400 (EDT)
From: Alon Levy <alevy@redhat.com>
Message-ID: <996330648.17914963.1345542194765.JavaMail.root@redhat.com>
In-Reply-To: <CAAu8pHt2-xeXwo_xDN+s783PdtTKKyMK7gMSYh+uWcA_j01W7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v9 5/5] (temp) FORTIFY_SOURCES hack
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com

> On Mon, Aug 20, 2012 at 1:26 PM, Alon Levy <alevy@redhat.com> wrote:
> > ---
> >  .gitmodules    | 3 +++
> >  compiler.h     | 7 +++++++
> >  spice-protocol | 1 +
> >  3 files changed, 11 insertions(+)
> >  create mode 160000 spice-protocol

I accidentally sent this patch, you can see the "(temp)" in the title.

> >
> > diff --git a/.gitmodules b/.gitmodules
> > index eca876f..ba6844b 100644
> > --- a/.gitmodules
> > +++ b/.gitmodules
> > @@ -19,3 +19,6 @@
> >  [submodule "roms/sgabios"]
> >         path = roms/sgabios
> >         url = git://git.qemu.org/sgabios.git
> > +[submodule "spice-protocol"]
> > +       path = spice-protocol
> > +       url = git://git.freedesktop.org/git/spice/spice-protocol
> > diff --git a/compiler.h b/compiler.h
> > index 07ba1f8..622aeda 100644
> > --- a/compiler.h
> > +++ b/compiler.h
> > @@ -57,4 +57,11 @@
> >  #define GCC_FMT_ATTR(n, m)
> >  #endif
> >
> > +/* Enable compile-time and run-time bounds-checking, and some
> > warnings. */
> > +#ifdef __OPTIMIZE__
> > +#if __OPTIMIZE__
> > +# define _FORTIFY_SOURCE 2
> > +#endif
> > +#endif
> 
> _FORTIFY_SOURCE is already defined by configure:
> if test "$debug" = "no" ; then
>   CFLAGS="-O2 -D_FORTIFY_SOURCE=2 $CFLAGS"
> fi
> 
> > +
> >  #endif /* COMPILER_H */
> > diff --git a/spice-protocol b/spice-protocol
> > new file mode 160000
> > index 0000000..26cd194
> > --- /dev/null
> > +++ b/spice-protocol
> > @@ -0,0 +1 @@
> > +Subproject commit 26cd1946a5c959a53c78fa16f1b3e84a9682121b
> > --
> > 1.7.11.2
> >
> >
> 
>