From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Hao Zeng <zenghao@kylinos.cn>,
pbonzini@redhat.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/arm: enable qxl for aarch64
Date: Fri, 12 May 2023 12:22:56 +0200 [thread overview]
Message-ID: <997e44b4-a7dc-d63a-1aea-2597dc87fb0d@linaro.org> (raw)
In-Reply-To: <CAFEAcA8tWWWvOAS=GCTnGD=Sv6h5pUWf3Cy4ux-FeF8s_BjzVw@mail.gmail.com>
On 12/5/23 11:56, Peter Maydell wrote:
> On Fri, 12 May 2023 at 10:11, Jonathan Cameron
> <Jonathan.Cameron@huawei.com> wrote:
>>
>> On Fri, 12 May 2023 17:08:03 +0800
>> Hao Zeng <zenghao@kylinos.cn> wrote:
>>
>>> Qemu does not support qxl graphics cards in arm, it is recommended to enable
>>>
>>> Signed-off-by: Hao Zeng <zenghao@kylinos.cn>
>>
>> Drive by comment.
>>
>>> ---
>>> hw/arm/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
>>> index 0f42c556d7..0305a4f4f3 100644
>>> --- a/hw/arm/Kconfig
>>> +++ b/hw/arm/Kconfig
>>> @@ -32,7 +32,7 @@ config ARM_VIRT
>>> select VIRTIO_MEM_SUPPORTED
>>> select ACPI_CXL
>>> select ACPI_HMAT
>>> -
>>> + select QXL
>> Keep the blank line here.
>
> I don't understand why QXL is special here -- isn't it
> just another PCI card? We already "imply PCI_DEVICES"
> so I would have expected that to work.
>
> I notice that the x86 "config PC" has an "imply QXL",
> though, so presumably it doesn't. Paolo, should this
> be fixed by making PCI_DEVICES pull in QXL, or by
> adding an "imply QXL" to the virt board ?
>
> As a third option, the mips "config LOONGSON3V"
> has "imply QXL if SPICE".
>
> I don't know what the right answer is here, but I
> suspect it should be the same thing in all three
> cases, not three different things :-)
I'm also confused because we already have in hw/display/Kconfig:
config QXL
bool
depends on SPICE && PCI
prev parent reply other threads:[~2023-05-12 10:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 9:08 [PATCH] hw/arm: enable qxl for aarch64 Hao Zeng
2023-05-12 9:11 ` Jonathan Cameron via
2023-05-12 9:56 ` Peter Maydell
2023-05-12 10:22 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=997e44b4-a7dc-d63a-1aea-2597dc87fb0d@linaro.org \
--to=philmd@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zenghao@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).