From: Paolo Bonzini <pbonzini@redhat.com>
To: Yury Kotov <yury-kotov@yandex-team.ru>,
"open list:Overall" <kvm@vger.kernel.org>
Cc: "open list:All patches CC here" <qemu-devel@nongnu.org>,
yc-core@yandex-team.ru
Subject: Re: [Qemu-devel] [PATCH] kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del
Date: Fri, 7 Jun 2019 13:46:11 +0200 [thread overview]
Message-ID: <99896404-c7d9-d2d0-ab01-ab67dcb0348f@redhat.com> (raw)
In-Reply-To: <20190607090830.18807-1-yury-kotov@yandex-team.ru>
On 07/06/19 11:08, Yury Kotov wrote:
> Signed-off-by: Yury Kotov <yury-kotov@yandex-team.ru>
> ---
> accel/kvm/kvm-all.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index 524c4ddfbd..e4ac3386cb 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -864,8 +864,8 @@ static void kvm_mem_ioeventfd_add(MemoryListener *listener,
> data, true, int128_get64(section->size),
> match_data);
> if (r < 0) {
> - fprintf(stderr, "%s: error adding ioeventfd: %s\n",
> - __func__, strerror(-r));
> + fprintf(stderr, "%s: error adding ioeventfd: %s (%d)\n",
> + __func__, strerror(-r), -r);
> abort();
> }
> }
> @@ -882,6 +882,8 @@ static void kvm_mem_ioeventfd_del(MemoryListener *listener,
> data, false, int128_get64(section->size),
> match_data);
> if (r < 0) {
> + fprintf(stderr, "%s: error deleting ioeventfd: %s (%d)\n",
> + __func__, strerror(-r), -r);
> abort();
> }
> }
> @@ -898,8 +900,8 @@ static void kvm_io_ioeventfd_add(MemoryListener *listener,
> data, true, int128_get64(section->size),
> match_data);
> if (r < 0) {
> - fprintf(stderr, "%s: error adding ioeventfd: %s\n",
> - __func__, strerror(-r));
> + fprintf(stderr, "%s: error adding ioeventfd: %s (%d)\n",
> + __func__, strerror(-r), -r);
> abort();
> }
> }
> @@ -917,6 +919,8 @@ static void kvm_io_ioeventfd_del(MemoryListener *listener,
> data, false, int128_get64(section->size),
> match_data);
> if (r < 0) {
> + fprintf(stderr, "%s: error deleting ioeventfd: %s (%d)\n",
> + __func__, strerror(-r), -r);
> abort();
> }
> }
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2019-06-07 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 9:08 [Qemu-devel] [PATCH] kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del Yury Kotov
2019-06-07 11:46 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99896404-c7d9-d2d0-ab01-ab67dcb0348f@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=yc-core@yandex-team.ru \
--cc=yury-kotov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).