From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C462BC433DF for ; Thu, 18 Jun 2020 19:20:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 911A7206F7 for ; Thu, 18 Jun 2020 19:20:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LGbKy+eF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 911A7206F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jm05e-0001BI-T1 for qemu-devel@archiver.kernel.org; Thu, 18 Jun 2020 15:20:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jm04y-0000bq-Jn for qemu-devel@nongnu.org; Thu, 18 Jun 2020 15:20:04 -0400 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:44346) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jm04w-0000sQ-2s for qemu-devel@nongnu.org; Thu, 18 Jun 2020 15:20:04 -0400 Received: by mail-pl1-x643.google.com with SMTP id bh7so2839112plb.11 for ; Thu, 18 Jun 2020 12:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zTEpJStbwpec8+oM3y3EvE/o3v/vYYV2Kl76GPb4ZZ4=; b=LGbKy+eFx3IeATyVhS/8yOZKfbNAFHpdjefWOpQibbQmeDO8j+tpRTDCSxekqT6aPh TeIz31pE2gmn1EXKG6/yl/ts6P+BPoaVOd2Qw5XeGNXg+ElifByq5P3G7W4xF3MiOly4 KmOX1GPHNAv8y6+CFWR2gD0twuiy8FK+TA8hSkG3QNm4tX2F6gYVRN6ciE4lXMT4FDgV gGTxR2LOcPyPn2KpM+AbXFJJuE03YLKPv0wLNMBns4hw7uJ9cB58HrTnbITk6X5pDIkD Duv1ZXc1RmAdH+h151clogxzb9seS4/MsFsluh0/lYOTGoZ9cICXE78iku3GCCI3V4hS Po1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zTEpJStbwpec8+oM3y3EvE/o3v/vYYV2Kl76GPb4ZZ4=; b=Q2N6HL/JOfrLJcWr89PZ5zAvbg06pNBKCNSUCdF2OM3gyvejtJk2NbHxiZL1A6Es/j ZGRch6olEuRbW92CHuS+1QUaqq3/ONaAc9jJPnUXj65ZN+8FzqCQO/cLFshMeVVkqO3z CZUM04Cby6jT8JFrSsf7bMovM08emDSeGa+Nl3hyKCtEhrzQoXzaKXtfL0DQhGtzgvbD jn5r6/vZqZL1bYn02KB+9N11TtVtLi+ypp17f1qX2PJbP+3d8v1mpyOlm3bt3LIU03jK pOuKZx5rQsOxbFW6/jOjgc4AQjnOZjnLHIYHL8Tg+qgkNuELoRSHbBN7whf3W0Y3sD4Q KeYw== X-Gm-Message-State: AOAM531Rw9QevxF+IkEBIvJSk6UZZrzB2ONR3BAwn9ytFrfCdcQHgqfk +fI59bUmXz3qZ9cGi2MjYNekCw== X-Google-Smtp-Source: ABdhPJwinLUereq+WnMDXKoQT8n7ZYBMUeprAqRAo09qdLhd4TNXALQ0Gx/vGhejI7v6F5lt3y/MkQ== X-Received: by 2002:a17:90a:d3c2:: with SMTP id d2mr5404142pjw.202.1592508000427; Thu, 18 Jun 2020 12:20:00 -0700 (PDT) Received: from [192.168.1.11] (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id k14sm3207368pgn.94.2020.06.18.12.19.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 12:19:59 -0700 (PDT) Subject: Re: [PATCH v7 14/42] target/arm: Add helper_probe_access To: Peter Maydell References: <20200603011317.473934-1-richard.henderson@linaro.org> <20200603011317.473934-15-richard.henderson@linaro.org> From: Richard Henderson Message-ID: <998a01bf-fb40-f075-fc08-747669c52b70@linaro.org> Date: Thu, 18 Jun 2020 12:19:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::643; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x643.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers , Stephen Long Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/18/20 6:33 AM, Peter Maydell wrote: > On Wed, 3 Jun 2020 at 02:13, Richard Henderson > wrote: >> >> Raise an exception if the given virtual memory is not accessible. >> >> Signed-off-by: Richard Henderson >> --- > >> diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c >> index 0ee2ef403e..b032829194 100644 >> --- a/target/arm/translate-a64.c >> +++ b/target/arm/translate-a64.c >> @@ -232,6 +232,19 @@ static void gen_address_with_allocation_tag0(TCGv_i64 dst, TCGv_i64 src) >> tcg_gen_andi_i64(dst, src, ~MAKE_64BIT_MASK(56, 4)); >> } >> >> +static void gen_probe_access(DisasContext *s, TCGv_i64 ptr, >> + MMUAccessType acc, int log2_size) >> +{ >> + TCGv_i32 t_acc = tcg_const_i32(acc); >> + TCGv_i32 t_idx = tcg_const_i32(get_mem_index(s)); >> + TCGv_i32 t_size = tcg_const_i32(1 << log2_size); >> + >> + gen_helper_probe_access(cpu_env, ptr, t_acc, t_idx, t_size); >> + tcg_temp_free_i32(t_acc); >> + tcg_temp_free_i32(t_idx); >> + tcg_temp_free_i32(t_size); >> +} > > This isn't called from anywhere -- clang is probably going to > complain about that. Ah, yes. I thought it would be helpful to split this patch, but I guess not. I'll merge with the next patch where it's used. r~