From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0733AC4332F for ; Mon, 30 Oct 2023 16:53:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxVVX-00053i-TL; Mon, 30 Oct 2023 12:52:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxVVL-00053Z-Ey for qemu-devel@nongnu.org; Mon, 30 Oct 2023 12:52:43 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxVVJ-0006vX-AW for qemu-devel@nongnu.org; Mon, 30 Oct 2023 12:52:43 -0400 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39UGq8w4019398; Mon, 30 Oct 2023 16:52:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=OPACZLq+6Con9+xnu14GglzWmKJRM8/oOCxdni6a3L0=; b=gMT0F1Dun4mPOZzwIqOl22rd8gaY7CAjtWz5Qwvx0uckGDzC7OHDCXcV4dfK/wAiuZCt dP5K3zFn997N20yY53cXUC24hCzlcN813nh2vGYZp3QAUZQt+MN0JHBWphRGfH3cpobw T/iEiSRzchCiu207zYfcUND6xouo910REcO3uGbUVj5q3cXbQIKWjITEmVb9iAFPP/Jm ooDhvzoAj2IsAn7eFbwXmTkrj7V1ihTZG/NktFp9As3nKUp6ND2Z3Ri/kSGcGXA39EKG gBwt33zuzZgfKPpxf5pKH1lmksXfolJP/XRfPK0xQ+pz8KHU2bD4ku8nN750lvZxT/io Bw== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u2gcwr04p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Oct 2023 16:52:36 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 39UF17mX011544; Mon, 30 Oct 2023 16:52:35 GMT Received: from smtprelay07.dal12v.mail.ibm.com ([172.16.1.9]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3u1e4kjarm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 Oct 2023 16:52:35 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay07.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 39UGqY3r31130086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Oct 2023 16:52:34 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 61B0258056; Mon, 30 Oct 2023 16:52:34 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 29C0558052; Mon, 30 Oct 2023 16:52:34 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTPS; Mon, 30 Oct 2023 16:52:34 +0000 (GMT) Message-ID: <998ed878-6cf2-42e3-a764-a2d222bf914c@linux.ibm.com> Date: Mon, 30 Oct 2023 12:52:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/14] tpm-sysbus: add plug handler for TPM on SysBus To: Joelle van Dyne , qemu-devel@nongnu.org Cc: Stefan Berger References: <20231029060404.71196-1-j@getutm.app> <20231029060404.71196-7-j@getutm.app> Content-Language: en-US From: Stefan Berger In-Reply-To: <20231029060404.71196-7-j@getutm.app> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: oq4IsOivC6tHHTNzpE_NMzV0KtSQmlSm X-Proofpoint-ORIG-GUID: oq4IsOivC6tHHTNzpE_NMzV0KtSQmlSm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-30_10,2023-10-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 priorityscore=1501 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=937 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2310300132 Received-SPF: pass client-ip=148.163.156.1; envelope-from=stefanb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/29/23 02:03, Joelle van Dyne wrote: > TPM needs to know its own base address in order to generate its DSDT > device entry. > > Signed-off-by: Joelle van Dyne > --- > include/sysemu/tpm.h | 4 ++++ > hw/tpm/tpm-sysbus.c | 33 +++++++++++++++++++++++++++++++++ > hw/tpm/meson.build | 1 + > 3 files changed, 38 insertions(+) > create mode 100644 hw/tpm/tpm-sysbus.c > > diff --git a/include/sysemu/tpm.h b/include/sysemu/tpm.h > index 1ee568b3b6..ffd300e607 100644 > --- a/include/sysemu/tpm.h > +++ b/include/sysemu/tpm.h > @@ -12,6 +12,8 @@ > #ifndef QEMU_TPM_H > #define QEMU_TPM_H > > +#include "qemu/osdep.h" > +#include "exec/hwaddr.h" > #include "qapi/qapi-types-tpm.h" > #include "qom/object.h" > > @@ -78,6 +80,8 @@ static inline TPMVersion tpm_get_version(TPMIf *ti) > return TPM_IF_GET_CLASS(ti)->get_version(ti); > } > > +void tpm_sysbus_plug(TPMIf *tpmif, Object *pbus, hwaddr pbus_base); > + > #else /* CONFIG_TPM */ > > #define tpm_init() (0) > diff --git a/hw/tpm/tpm-sysbus.c b/hw/tpm/tpm-sysbus.c > new file mode 100644 > index 0000000000..ef0592b837 > --- /dev/null > +++ b/hw/tpm/tpm-sysbus.c > @@ -0,0 +1,33 @@ A header in this new file would be good. Otherwise LGTM.   Stefan > +#include "sysemu/tpm.h" > +#include "hw/platform-bus.h" > +#include "hw/sysbus.h" > +#include "qapi/error.h"