From: "Montes, Julio" <julio.montes@intel.com>
To: "sgarzare@redhat.com" <sgarzare@redhat.com>
Cc: "dgilbert@redhat.com" <dgilbert@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] monitor: vnc: Fix compilation error if CONFIG_VNC is disable
Date: Wed, 3 Jul 2019 13:23:56 +0000 [thread overview]
Message-ID: <999558d036462e63c7ee389b1a883c21b8b6376b.camel@intel.com> (raw)
In-Reply-To: <20190703082159.ewnjivevv2wzmdxm@steredhat>
On Wed, 2019-07-03 at 10:21 +0200, Stefano Garzarella wrote:
> On Tue, Jul 02, 2019 at 07:01:31PM +0000, Julio Montes wrote:
> > How to reproduce it?
> > ===
> >
> > ```
> > $ ./configure --disable-spice --disable-vte --disable-vnc \
> > --disable-vnc-jpeg --disable-vnc-png --disable-vnc-sasl
> > $ make
> > ...
> > monitor/hmp-cmds.c: In function ‘hmp_change’:
> > monitor/hmp-cmds.c:1985:17: error: unused variable ‘hmp_mon’
> > [-Werror=unused-variable]
> > MonitorHMP *hmp_mon = container_of(mon, MonitorHMP, common);
> > ```
> >
> > Fix
> > ===
> >
> > Move `hmp_mon` variable within the `CONFIG_VNC` block
> >
>
> Hi Julio,
> thanks for the patch, but Christophe sent a very similar patch last
> week:
> https://patchew.org/QEMU/20190625123905.25434-1-dinechin@redhat.com/
Thanks Stefano, please ignore this patch :)
>
> Cheers,
> Stefano
prev parent reply other threads:[~2019-07-03 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 19:01 [Qemu-devel] [PATCH] monitor: vnc: Fix compilation error if CONFIG_VNC is disable Julio Montes
2019-07-03 1:40 ` no-reply
2019-07-03 8:21 ` Stefano Garzarella
2019-07-03 13:23 ` Montes, Julio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=999558d036462e63c7ee389b1a883c21b8b6376b.camel@intel.com \
--to=julio.montes@intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).