From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MSbop-0008In-Sr
	for qemu-devel@nongnu.org; Sun, 19 Jul 2009 15:13:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MSbok-0008Em-9s
	for qemu-devel@nongnu.org; Sun, 19 Jul 2009 15:13:06 -0400
Received: from [199.232.76.173] (port=44901 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MSbok-0008EZ-2F
	for qemu-devel@nongnu.org; Sun, 19 Jul 2009 15:13:02 -0400
Received: from mail.gmx.net ([213.165.64.20]:33971)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <herbszt@gmx.de>) id 1MSboj-0003Hh-FF
	for qemu-devel@nongnu.org; Sun, 19 Jul 2009 15:13:01 -0400
Message-ID: <99C86C65A77F471C935BFD9DB00AC5F8@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <1247320357-7928-1-git-send-email-matthew@theiselins.net>
In-Reply-To: <1247320357-7928-1-git-send-email-matthew@theiselins.net>
Date: Sun, 19 Jul 2009 21:10:54 +0200
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC] [PATCH] 3C90X Emulation
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Matthew Iselin <matthew@theiselins.net>
Cc: qemu-devel@nongnu.org

Matthew Iselin wrote:
> This patch adds a basic 3C90X emulation to QEMU.
> 
> I have tested this with Linux kernels 2.4 and 2.6 (DSL and Ubuntu), and
> Pedigree.
> 
> This has been ported from the PearPC 3C90X emulation, with significant
> modifications to enable it to work on 2.6 kernels.
> 
> Signed-off-by: Matthew Iselin <matthew@theiselins.net>
> ---
> Makefile.target |    1 +
> hw/3c90x.c      | 2421 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> hw/pci.c        |    2 +
> hw/pci_ids.h    |    3 +
> 4 files changed, 2427 insertions(+), 0 deletions(-)
> create mode 100644 hw/3c90x.c

  CC    i386-softmmu/3c90x.o
cc1: warnings being treated as errors
hw/3c90x.c: In function 'a3c90x_io_readx':
hw/3c90x.c:2028: warning: comparison is always true due to limited range of data type
hw/3c90x.c: In function 'a3c90x_io_writex':
hw/3c90x.c:2096: warning: comparison is always true due to limited range of data type
make[1]: *** [3c90x.o] Error 1
make: *** [subdir-i386-softmmu] Error 2

> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
> index 3afe674..872cca8 100644
> --- a/hw/pci_ids.h
> +++ b/hw/pci_ids.h
> @@ -75,6 +75,9 @@
> #define PCI_VENDOR_ID_REALTEK            0x10ec
> #define PCI_DEVICE_ID_REALTEK_8139       0x8139
> 
> +#define PCI_VENDOR_ID_3COM               0x10b7
> +#define PCI_DEVICE_ID_3COM_3C90X         0x9200
> +
> #define PCI_VENDOR_ID_XILINX             0x10ee
> 
> #define PCI_VENDOR_ID_MARVELL            0x11ab

The file content is supposed to be sorted:

/* Vendors and devices.  Sort key: vendor first, device next. */

- Sebastian