From: Richard Henderson <richard.henderson@linaro.org>
To: Joe Komlodi <joe.komlodi@xilinx.com>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org
Subject: Re: [PATCH 1/1] target/arm: Check NaN mode before silencing NaN
Date: Fri, 25 Jun 2021 19:18:27 -0700 [thread overview]
Message-ID: <99a806cf-8c54-a504-c51b-bd094a2773b3@linaro.org> (raw)
In-Reply-To: <1624662174-175828-2-git-send-email-joe.komlodi@xilinx.com>
On 6/25/21 4:02 PM, Joe Komlodi wrote:
> If the CPU is running in default NaN mode (FPCR.DN == 1) and we execute
> FRSQRTE, FRECPE, or FRECPX with a signaling NaN, parts_silence_nan_frac() will
> assert due to fpst->default_nan_mode being set.
>
> To avoid this, we check to see what NaN mode we're running in before we call
> floatxx_silence_nan().
>
> Signed-off-by: Joe Komlodi<joe.komlodi@xilinx.com>
> ---
> target/arm/helper-a64.c | 12 +++++++++---
> target/arm/vfp_helper.c | 24 ++++++++++++++++++------
> 2 files changed, 27 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-06-26 2:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 23:02 [PATCH 0/1] target/arm: Check NaN mode before silencing NaN Joe Komlodi
2021-06-25 23:02 ` [PATCH 1/1] " Joe Komlodi
2021-06-26 2:18 ` Richard Henderson [this message]
2021-06-28 14:54 ` [PATCH 0/1] " Peter Maydell
2021-06-28 15:04 ` Richard Henderson
2021-06-29 9:38 ` Peter Maydell
2021-07-15 19:29 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a806cf-8c54-a504-c51b-bd094a2773b3@linaro.org \
--to=richard.henderson@linaro.org \
--cc=joe.komlodi@xilinx.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).