From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, "Peter Xu" <peterx@redhat.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Philippe Mathieu-Daudé" <philippe.mathieu-daude@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: should ioapic_service really be modelling cpu writes?
Date: Fri, 11 Nov 2022 14:14:58 +0100 [thread overview]
Message-ID: <99a89e48-768c-4cc2-ead4-d2014aec7d44@redhat.com> (raw)
In-Reply-To: <87r0y9d623.fsf@linaro.org>
On 11/11/22 13:26, Alex Bennée wrote:
> if (addr > 0xfff || !index) {
> switch (attrs.requester_type) {
> }
> MSIMessage msi = { .address = addr, .data = val };
> apic_send_msi(&msi);
> return MEMTX_OK;
> }
> which at least gets things booting properly. Does this seem like a
> better modelling of the APIC behaviour?
Yes and you don't even need the "if", just do MTRT_CPU vs everything else.
Paolo
next prev parent reply other threads:[~2022-11-11 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 17:01 should ioapic_service really be modelling cpu writes? Alex Bennée
2022-11-10 17:55 ` Alex Bennée
2022-11-10 22:42 ` Peter Xu
2022-11-11 11:08 ` Paolo Bonzini
2022-11-11 12:26 ` Alex Bennée
2022-11-11 13:14 ` Paolo Bonzini [this message]
2022-11-11 14:00 ` Alex Bennée
2022-11-11 15:57 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99a89e48-768c-4cc2-ead4-d2014aec7d44@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philippe.mathieu-daude@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).