From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 1/2] hw/timer/hpet: Remove dead code
Date: Thu, 3 Sep 2020 15:59:59 +0200 [thread overview]
Message-ID: <99ac9ba8-9a6d-dea6-c7eb-387723fe5fcf@redhat.com> (raw)
In-Reply-To: <20200903134506.440082-2-philmd@redhat.com>
On 03/09/2020 15.45, Philippe Mathieu-Daudé wrote:
> This code was never compiled/used, remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/timer/hpet.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
> index 380acfa7c8a..b683f64f1d3 100644
> --- a/hw/timer/hpet.c
> +++ b/hw/timer/hpet.c
> @@ -416,20 +416,6 @@ static void hpet_del_timer(HPETTimer *t)
> update_irq(t, 0);
> }
>
> -#ifdef HPET_DEBUG
> -static uint32_t hpet_ram_readb(void *opaque, hwaddr addr)
> -{
> - printf("qemu: hpet_read b at %" PRIx64 "\n", addr);
> - return 0;
> -}
> -
> -static uint32_t hpet_ram_readw(void *opaque, hwaddr addr)
> -{
> - printf("qemu: hpet_read w at %" PRIx64 "\n", addr);
> - return 0;
> -}
> -#endif
> -
> static uint64_t hpet_ram_read(void *opaque, hwaddr addr,
> unsigned size)
> {
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-09-03 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 13:45 [PATCH 0/2] hw/timer/hpet: Trivial format string fix Philippe Mathieu-Daudé
2020-09-03 13:45 ` [PATCH 1/2] hw/timer/hpet: Remove dead code Philippe Mathieu-Daudé
2020-09-03 13:59 ` Thomas Huth [this message]
2020-09-09 13:34 ` Laurent Vivier
2020-09-03 13:45 ` [PATCH 2/2] hw/timer/hpet: Fix DPRINTF format string Philippe Mathieu-Daudé
2020-09-03 14:04 ` Thomas Huth
2020-09-09 13:34 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99ac9ba8-9a6d-dea6-c7eb-387723fe5fcf@redhat.com \
--to=thuth@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).