Re: [PATCH v2 09/17] hw/arm/aspeed: Attach SPI device to AST1700 model

["Cédric Le Goater" <clg@kaod.org>]

On 11/6/25 11:11, Kane Chen wrote:
> Hi Nabih,
> 
> Thanks for pointing this out. It seems I need to add the abstract attribute to the aspeed_ast1700_info
> structure, as shown below:
> 
> diff --git a/hw/misc/aspeed_ast1700.c b/hw/misc/aspeed_ast1700.c
> index 3d9a920a7a..ec95217f16 100644
> --- a/hw/misc/aspeed_ast1700.c
> +++ b/hw/misc/aspeed_ast1700.c
> @@ -286,6 +286,7 @@ static const TypeInfo aspeed_ast1700_info = {
>       .instance_size = sizeof(AspeedAST1700SoCState),
>       .class_init    = aspeed_ast1700_class_init,
>       .instance_init = aspeed_ast1700_instance_init,
> +    .abstract      = true,
>   };

Hmm,

Please rework all typenames in aspeed_ast1700_instance_init(): remove
all snprintf() and use directly strings like "aspeed.gpio-ast2700".
For now, It should be fine. We will see if extensions are needed
in the future.

Also, I don't see why you need :

   static const TypeInfo aspeed_ast1700_ast2700_info = {
       .name = TYPE_ASPEED_AST1700_AST2700,
       .parent = TYPE_ASPEED_AST1700,
   };

Can't you use directly TYPE_ASPEED_AST1700 instead  ?

> On the other hand, I encountered a timeout error while running the make check-functional test.
> I need to investigate why the test case failed.
> Once this issue is clarified, I’ll submit another patch for further review.

Wait for some feedback from me before resending.

Thanks,

C.