From: G 3 <programmingkidx@gmail.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC
Date: Sat, 20 Jun 2009 20:41:43 -0400 [thread overview]
Message-ID: <99cfa4f95f7ce8cbae59b168aee645b8@gmail.com> (raw)
In-Reply-To: <4A3D72B5.5080806@codemonkey.ws>
On Jun 20, 2009, at 7:37 PM, Anthony Liguori wrote:
> Jamie Lokier wrote:
>> If O_FSYNC and O_SYNC do the same thing, and O_SYNC is used anywhere,
>> there's no harm in this for portability:
>>
>> #if !defined(O_SYNC) && defined(O_FSYNC)
>> #define O_SYNC O_FSYNC
>> #endif
>>
>> The patch assumes O_FSYNC is defined if O_SYNC isn't, which is wrong.
>>
>
> For what this patch is, it really isn't that important IMHO.
>
> This is just a work around for a broken platform.
>
Even though you are correct, did you have to add the 'broken platform'
remark?
next prev parent reply other threads:[~2009-06-21 0:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 2:22 [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC m a
2009-06-20 14:31 ` Anthony Liguori
2009-06-20 18:59 ` Avi Kivity
2009-06-20 19:03 ` François Revol
2009-06-20 19:15 ` Avi Kivity
2009-06-20 23:25 ` Jamie Lokier
2009-06-21 10:01 ` Andreas Färber
2009-06-24 18:25 ` Jamie Lokier
2009-06-24 18:54 ` Andreas Färber
2009-06-24 18:59 ` Filip Navara
2009-06-24 19:08 ` Jamie Lokier
2009-06-20 20:46 ` Anthony Liguori
2009-06-21 9:01 ` Avi Kivity
2009-06-20 19:16 ` Christoph Hellwig
2009-06-20 23:30 ` Jamie Lokier
2009-06-20 23:37 ` Anthony Liguori
2009-06-21 0:41 ` G 3 [this message]
2009-06-24 18:27 ` Jamie Lokier
2009-06-21 0:46 ` G 3
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99cfa4f95f7ce8cbae59b168aee645b8@gmail.com \
--to=programmingkidx@gmail.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).