From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Hawkins Jiawei" <yin31149@gmail.com>,
"Eugenio Pérez" <eperezma@redhat.com>
Subject: [PULL 06/83] vhost: Expose vhost_svq_available_slots()
Date: Wed, 18 Oct 2023 11:53:38 -0400 [thread overview]
Message-ID: <99d6a32469debf1a48921125879b614d15acfb7a.1697644299.git.mst@redhat.com> (raw)
In-Reply-To: <cover.1697644299.git.mst@redhat.com>
From: Hawkins Jiawei <yin31149@gmail.com>
Next patches in this series will delay the polling
and checking of buffers until either the SVQ is
full or control commands shadow buffers are full,
no longer perform an immediate poll and check of
the device's used buffers for each CVQ state load command.
To achieve this, this patch exposes
vhost_svq_available_slots(), allowing QEMU to know
whether the SVQ is full.
Signed-off-by: Hawkins Jiawei <yin31149@gmail.com>
Acked-by: Eugenio Pérez <eperezma@redhat.com>
Message-Id: <25938079f0bd8185fd664c64e205e629f7a966be.1697165821.git.yin31149@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/vhost-shadow-virtqueue.h | 1 +
hw/virtio/vhost-shadow-virtqueue.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-shadow-virtqueue.h b/hw/virtio/vhost-shadow-virtqueue.h
index 5bce67837b..19c842a15b 100644
--- a/hw/virtio/vhost-shadow-virtqueue.h
+++ b/hw/virtio/vhost-shadow-virtqueue.h
@@ -114,6 +114,7 @@ typedef struct VhostShadowVirtqueue {
bool vhost_svq_valid_features(uint64_t features, Error **errp);
+uint16_t vhost_svq_available_slots(const VhostShadowVirtqueue *svq);
void vhost_svq_push_elem(VhostShadowVirtqueue *svq,
const VirtQueueElement *elem, uint32_t len);
int vhost_svq_add(VhostShadowVirtqueue *svq, const struct iovec *out_sg,
diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c
index e731b1d2ea..fc5f408f77 100644
--- a/hw/virtio/vhost-shadow-virtqueue.c
+++ b/hw/virtio/vhost-shadow-virtqueue.c
@@ -66,7 +66,7 @@ bool vhost_svq_valid_features(uint64_t features, Error **errp)
*
* @svq: The svq
*/
-static uint16_t vhost_svq_available_slots(const VhostShadowVirtqueue *svq)
+uint16_t vhost_svq_available_slots(const VhostShadowVirtqueue *svq)
{
return svq->num_free;
}
--
MST
next prev parent reply other threads:[~2023-10-18 15:54 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 15:53 [PULL 00/83] virtio,pc,pci: features, cleanups Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 01/83] vdpa: Use iovec for vhost_vdpa_net_cvq_add() Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 02/83] vdpa: Avoid using vhost_vdpa_net_load_*() outside vhost_vdpa_net_load() Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 03/83] vdpa: Check device ack in vhost_vdpa_net_load_rx_mode() Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 04/83] vdpa: Move vhost_svq_poll() to the caller of vhost_vdpa_net_cvq_add() Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 05/83] vdpa: Introduce cursors to vhost_vdpa_net_loadx() Michael S. Tsirkin
2023-10-18 15:53 ` Michael S. Tsirkin [this message]
2023-10-18 15:53 ` [PULL 07/83] vdpa: Send cvq state load commands in parallel Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 08/83] vdpa: Restore hash calculation state Michael S. Tsirkin
2023-10-19 16:32 ` Stefan Hajnoczi
2023-10-19 18:07 ` Michael S. Tsirkin
2023-10-20 0:58 ` Hawkins Jiawei
2023-10-19 18:34 ` Michael S. Tsirkin
2023-10-19 18:49 ` Stefan Hajnoczi
2023-10-18 15:53 ` [PULL 09/83] vdpa: Allow VIRTIO_NET_F_HASH_REPORT in SVQ Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 10/83] vdpa: Add SetSteeringEBPF method for NetClientState Michael S. Tsirkin
2023-10-18 15:53 ` [PULL 11/83] vdpa: Restore receive-side scaling state Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 12/83] vdpa: Allow VIRTIO_NET_F_RSS in SVQ Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 13/83] tests: test-smp-parse: Add the test for cores/threads per socket helpers Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 14/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 count test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 15/83] tests: bios-tables-test: Add test for smbios type4 count Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 16/83] tests: bios-tables-test: Add ACPI table binaries for smbios type4 count test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 17/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 core " Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 18/83] tests: bios-tables-test: Add test for smbios type4 core count Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 19/83] tests: bios-tables-test: Add ACPI table binaries for smbios type4 core count test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 20/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 core count2 test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 21/83] tests: bios-tables-test: Extend smbios core count2 test to cover general topology Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 22/83] tests: bios-tables-test: Update ACPI table binaries for smbios core count2 test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 23/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 thread count test Michael S. Tsirkin
2023-10-18 15:54 ` [PULL 24/83] tests: bios-tables-test: Add test for smbios type4 thread count Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 25/83] tests: bios-tables-test: Add ACPI table binaries for smbios type4 thread count test Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 26/83] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 thread count2 test Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 27/83] tests: bios-tables-test: Add test for smbios type4 thread count2 Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 28/83] tests: bios-tables-test: Add ACPI table binaries for smbios type4 thread count2 test Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 29/83] vhost-user: strip superfluous whitespace Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 30/83] vhost-user: tighten "reply_supported" scope in "set_vring_addr" Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 31/83] vhost-user: factor out "vhost_user_write_sync" Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 32/83] vhost-user: flatten "enforce_reply" into "vhost_user_write_sync" Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 33/83] vhost-user: hoist "write_sync", "get_features", "get_u64" Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 34/83] vhost-user: allow "vhost_set_vring" to wait for a reply Michael S. Tsirkin
2023-10-18 15:55 ` [PULL 35/83] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 36/83] memory: initialize 'fv' in MemoryRegionCache to make Coverity happy Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 37/83] vhost-user: do not send RESET_OWNER on device reset Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 38/83] vhost-backend: remove vhost_kernel_reset_device() Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 39/83] virtio: call ->vhost_reset_device() during reset Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 40/83] hw/i386/acpi-build: Remove build-time assertion on PIIX/ICH9 reset registers being identical Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 41/83] timer/i8254: Fix one shot PIT mode Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 42/83] hw/display: fix memleak from virtio_add_resource Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 43/83] hw/i386/pc: Merge two if statements into one Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 44/83] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 45/83] hw/i386/pc_piix: Assign PIIX3's ISA interrupts before its realize() Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 46/83] hw/isa/piix3: Resolve redundant PIIX_NUM_PIC_IRQS Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 47/83] hw/i386/pc_piix: Wire PIIX3's ISA interrupts by new "isa-irqs" property Michael S. Tsirkin
2023-10-18 15:56 ` [PULL 48/83] hw/i386/pc_piix: Remove redundant "piix3" variable Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 49/83] hw/isa/piix3: Rename "pic" attribute to "isa_irqs_in" Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 50/83] hw/i386/pc_q35: Wire ICH9 LPC function's interrupts before its realize() Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 51/83] hw/isa/piix3: Wire PIC IRQs to ISA bus in host device Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 52/83] hw/i386/pc: Wire RTC ISA IRQs in south bridges Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 53/83] hw/isa/piix3: Create IDE controller in host device Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 54/83] hw/isa/piix3: Create USB " Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 55/83] hw/isa/piix3: Create power management " Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 56/83] hw/isa/piix3: Drop the "3" from PIIX base class name Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 57/83] hw/isa/piix4: Remove unused inbound ISA interrupt lines Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 58/83] hw/isa/piix4: Rename "isa" attribute to "isa_irqs_in" Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 59/83] hw/isa/piix4: Rename reset control operations to match PIIX3 Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 60/83] hw/isa/piix4: Reuse struct PIIXState from PIIX3 Michael S. Tsirkin
2023-10-18 15:57 ` [PULL 61/83] hw/isa/piix3: Merge hw/isa/piix4.c Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 62/83] hw/isa/piix: Allow for optional PIC creation in PIIX3 Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 63/83] hw/isa/piix: Allow for optional PIT " Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 64/83] hw/isa/piix: Harmonize names of reset control memory regions Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 65/83] hw/isa/piix: Share PIIX3's base class with PIIX4 Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 66/83] hw/isa/piix: Reuse PIIX3 base class' realize method in PIIX4 Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 67/83] hw/isa/piix: Rename functions to be shared for PCI interrupt triggering Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 68/83] hw/isa/piix: Reuse PIIX3's PCI interrupt triggering in PIIX4 Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 69/83] hw/isa/piix: Resolve duplicate code regarding PCI interrupt wiring Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 70/83] hw/isa/piix: Implement multi-process QEMU support also for PIIX4 Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 71/83] hw/i386/pc_piix: Make PIIX4 south bridge usable in PC machine Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 72/83] vhost-user-common: send get_inflight_fd once Michael S. Tsirkin
2023-10-18 15:58 ` [PULL 73/83] vhost: move and rename the conn retry times Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 74/83] vhost-user-scsi: support reconnect to backend Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 75/83] vhost-user-scsi: start vhost when guest kicks Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 76/83] vhost-user: fix lost reconnect Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 77/83] hw/i386/cxl: ensure maxram is greater than ram size for calculating cxl range Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 78/83] tests/acpi: Allow update of DSDT.cxl Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 79/83] hw/cxl: Add QTG _DSM support for ACPI0017 device Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 80/83] tests/acpi: Update DSDT.cxl with QTG DSM Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 81/83] vhost-user: Fix protocol feature bit conflict Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 82/83] MAINTAINERS: Add include/hw/intc/i8259.h to the PC chip section Michael S. Tsirkin
2023-10-18 15:59 ` [PULL 83/83] intel-iommu: Report interrupt remapping faults, fix return value Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99d6a32469debf1a48921125879b614d15acfb7a.1697644299.git.mst@redhat.com \
--to=mst@redhat.com \
--cc=eperezma@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yin31149@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).