From: Laurent Vivier <laurent@vivier.eu>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Pranith Kumar <bobby.prani@gmail.com>,
Riku Voipio <riku.voipio@iki.fi>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"Wirth, Allan" <awirth@akamai.com>
Subject: Re: [Qemu-devel] [PATCH v2] linux-user: Add signal handling support for x86_64
Date: Sun, 26 Feb 2017 14:04:07 +0100 [thread overview]
Message-ID: <99e997e4-c147-6e38-863b-4138d68a2fbd@vivier.eu> (raw)
In-Reply-To: <CAFEAcA-UCMkEREVQKFALDu==Y5z9wPkS2YOEkzOcD-xsv29BUg@mail.gmail.com>
Le 26/02/2017 à 13:39, Peter Maydell a écrit :
> On 26 February 2017 at 12:29, Laurent Vivier <laurent@vivier.eu> wrote:
>> Le 26/02/2017 à 00:04, Pranith Kumar a écrit :
>>> Note that x86_64 has only _rt signal handlers. This implementation
>>> attempts to share code with the x86_32 implementation.
>
>>> + struct target_fpreg st[8];
>>
>> Why don't you keep the original name "_st"?
>
> I suspect I asked for that in an earlier round of review
> on the basis that names with underscores are reserved
> namespace. Looking more closely at the rules though that's
> a bit over-conservative for a struct field name because
> _ followed by lowercase is only reserved in the global
> name space (unlike __ or _ followed by uppercase, which
> could be a macro). So using _st here isn't wrong, but
> on the other hand there's not much reason to use the
> underscore I think.
OK, thanks for the explanation.
Laurent
next prev parent reply other threads:[~2017-02-26 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 23:04 [Qemu-devel] [PATCH v2] linux-user: Add signal handling support for x86_64 Pranith Kumar
2017-02-26 12:29 ` Laurent Vivier
2017-02-26 12:39 ` Peter Maydell
2017-02-26 13:04 ` Laurent Vivier [this message]
2017-02-26 16:51 ` Pranith Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99e997e4-c147-6e38-863b-4138d68a2fbd@vivier.eu \
--to=laurent@vivier.eu \
--cc=awirth@akamai.com \
--cc=bobby.prani@gmail.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).