Re: [PATCH v5 2/7] plugins: save value during memory accesses

[Pierrick Bouvier <pierrick.bouvier@linaro.org>]

On 7/5/24 09:34, Richard Henderson wrote:
> On 7/4/24 17:34, Pierrick Bouvier wrote:
>> +static void
>> +plugin_gen_mem_callbacks_i32(TCGv_i32 val,
>> +                             TCGv_i64 copy_addr, TCGTemp *orig_addr,
>> +                             MemOpIdx oi, enum qemu_plugin_mem_rw rw)
>> +{
>> +#ifdef CONFIG_PLUGIN
>> +    if (tcg_ctx->plugin_insn != NULL) {
>> +        tcg_gen_st_i32(val, tcg_env,
>> +                       offsetof(CPUState, neg.plugin_mem_value_low) -
>> +                       sizeof(CPUState));
>> +        plugin_gen_mem_callbacks(copy_addr, orig_addr, oi, rw);
>> +    }
>> +#endif
>> +}
> 
> You need the big-endian offset for the low half of the uint64_t:
> 
>     HOST_BIG_ENDIAN * 4.
> 

Oh right, thanks. Will fix in v6.

> 
> r~