From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, thuth@redhat.com, david@redhat.com
Subject: Re: [Qemu-devel] [PATCH] tcg: remove softfloat from --disable-tcg builds
Date: Wed, 23 May 2018 00:06:10 +0200 [thread overview]
Message-ID: <9a4ac337-762c-7ad7-5cfe-dfc6554bcc71@redhat.com> (raw)
In-Reply-To: <724510e7-e739-5f88-b20b-9e27376a3438@linaro.org>
On 22/05/2018 22:53, Richard Henderson wrote:
> On 05/22/2018 12:20 PM, Paolo Bonzini wrote:
>> Even though the presence of softfloat does not cause --disable-tcg builds to fail,
>> it is the single largest .o file in them. Remove it, since TCG is the only client.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> Makefile.target | 2 +-
>> hw/i386/x86-iommu-stub.c | 132 +++++++++++++++++++++++++++++++++++++++
>
> Assuming this wasn't supposed to be here.
Oops, no it wasn't. Thanks for the quick review!
Paolo
>> 2 files changed, 133 insertions(+), 1 deletion(-)
>> create mode 100644 hw/i386/x86-iommu-stub.c
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index d0ec77a307..dad2cf8778 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -97,7 +97,7 @@ obj-$(CONFIG_TCG) += tcg/tcg.o tcg/tcg-op.o tcg/tcg-op-vec.o tcg/tcg-op-gvec.o
>> obj-$(CONFIG_TCG) += tcg/tcg-common.o tcg/optimize.o
>> obj-$(CONFIG_TCG_INTERPRETER) += tcg/tci.o
>> obj-$(CONFIG_TCG_INTERPRETER) += disas/tci.o
>> -obj-y += fpu/softfloat.o
>> +obj-$(CONFIG_TCG) += fpu/softfloat.o
>
> But for this change alone,
> Acked-by: Richard Henderson <richard.henderson@linaro.org>
>
> r~
>
next prev parent reply other threads:[~2018-05-22 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 19:20 [Qemu-devel] [PATCH] tcg: remove softfloat from --disable-tcg builds Paolo Bonzini
2018-05-22 19:26 ` no-reply
2018-05-22 19:27 ` Peter Maydell
2018-05-22 22:07 ` Paolo Bonzini
2018-05-22 20:53 ` Richard Henderson
2018-05-22 22:06 ` Paolo Bonzini [this message]
2018-05-23 4:34 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a4ac337-762c-7ad7-5cfe-dfc6554bcc71@redhat.com \
--to=pbonzini@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).