From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 025BDC433B4 for ; Thu, 29 Apr 2021 12:58:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 628A761423 for ; Thu, 29 Apr 2021 12:58:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 628A761423 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lc6FX-0005Ul-Ev for qemu-devel@archiver.kernel.org; Thu, 29 Apr 2021 08:58:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52608) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lc6EO-0004o9-2T for qemu-devel@nongnu.org; Thu, 29 Apr 2021 08:57:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lc6EK-0002Zl-Vb for qemu-devel@nongnu.org; Thu, 29 Apr 2021 08:57:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619701039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oti8ATbYq8Jbp2hVZiDT2qJSdqRp1r/F01P/IkBwRLM=; b=JfQj0lRYnrQdrL4P7QDFb/W3MQ5LzcVX9YuxbgCgrIkj3lv7JCba3Nx9HgKChZtAcmGW6K xXClRoko1a+lkcLLE9wA7lAeHCwdfbwV89tvQPncvGA1qEyqLrUKu8082a8dnggJtRHLYb rPFFCsTnNphhysQWkARB040jtP2Yyks= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-84-PsZx4xfSPPmaHtS7-hf_YA-1; Thu, 29 Apr 2021 08:57:16 -0400 X-MC-Unique: PsZx4xfSPPmaHtS7-hf_YA-1 Received: by mail-wr1-f69.google.com with SMTP id 61-20020adf84430000b029010b4cd88298so6941172wrf.21 for ; Thu, 29 Apr 2021 05:57:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Oti8ATbYq8Jbp2hVZiDT2qJSdqRp1r/F01P/IkBwRLM=; b=PNnZb9fqC6+OujMxHENmNRvm0lxA7uXI26t9BMCL05r04rWvH75WKfw1EvfQiCc0jz SOC5wIFSOpx/bCCFPeFeKnl1wXRhIMR4Nwplnznpx/uIOg6zUH5YYICOeVlNuyITn+vt M+WFpI702uDFTD4IYxMu+RSQUOM+81yqQ1jFfQgYjZZT7nSBb/NDuHouXxL945GQVrCx x1npym+EDefG+3g92dgxpehaT/IWuWqEa5Esum141oYsnndbDllULfPtrp2vc1N4Qo/N qJ+By4M2PJJGZMk7IkaAULmp/A9mcHDDVWnzb/wDeLkocq4XVE4FOpnsFywmaibpNHGp kT8Q== X-Gm-Message-State: AOAM532DIxJriQ3gbK5O0YYux3T42mUBEKTG9TRfoCSijineqFX/rRTe q1xkNjjygOcKNcGqqFxtQdnGrTtVGO2rupyMP8/3nI0KpXS7lzVDl7IV6E3YzQOKjHloJvegEgx uBrObGoK2REBdT8U= X-Received: by 2002:a1c:35c6:: with SMTP id c189mr10038486wma.127.1619701035740; Thu, 29 Apr 2021 05:57:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoR0rv/ZodLw/VmSMvtA70ZkWnL9QIIwW9yILcmZmsQJ7CKQK5QIzPBaEhxM5RZuY/6Rb3mw== X-Received: by 2002:a1c:35c6:: with SMTP id c189mr10038461wma.127.1619701035543; Thu, 29 Apr 2021 05:57:15 -0700 (PDT) Received: from [192.168.1.19] (anancy-651-1-208-144.w109-217.abo.wanadoo.fr. [109.217.237.144]) by smtp.gmail.com with ESMTPSA id t17sm3538717wmq.12.2021.04.29.05.57.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Apr 2021 05:57:15 -0700 (PDT) Subject: Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210415163304.4120052-1-philmd@redhat.com> <20210415163304.4120052-13-philmd@redhat.com> <03eed9c3-0670-f262-a2fa-172639b8ad77@redhat.com> <874kfqs5gl.fsf@linaro.org> <763dbed9-35e9-0f85-3b94-01bffc7fcbf8@redhat.com> <871raus00j.fsf@linaro.org> <97b2e23c-bbb2-f2cc-bddd-6047d0cbe0be@redhat.com> Message-ID: <9a4dfc32-91a7-df14-2601-f175c97a1dd5@redhat.com> Date: Thu, 29 Apr 2021 14:57:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <97b2e23c-bbb2-f2cc-bddd-6047d0cbe0be@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.22, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Andrew Jones , =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , Eduardo Habkost , "Michael S. Tsirkin" , Juan Quintela , Richard Henderson , qemu-devel@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, "Emilio G . Cota" , Claudio Fontana , Paolo Bonzini , Thomas Huth , Igor Mammedov , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/28/21 9:12 PM, Philippe Mathieu-Daudé wrote: > On 4/28/21 9:04 PM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> On 4/28/21 7:06 PM, Alex Bennée wrote: >>>> Philippe Mathieu-Daudé writes: >>>> >>>>> Alex, Richard, do you mind reviewing this one please? >>>> >>>> Isn't it already merged (with my r-b tag no less ;-) >>>> >>>> f77147cd4de8c726f89b2702f7a9d0c9711d8875 >>> >>> See ... >>> >>>> Author: Philippe Mathieu-Daudé >>>> AuthorDate: Fri Jan 22 21:44:31 2021 +0100 >>>> Commit: Paolo Bonzini >>>> CommitDate: Mon Feb 8 14:43:55 2021 +0100 >>>> >>>>> >>>>> On 4/15/21 6:33 PM, Philippe Mathieu-Daudé wrote: >>>>>> From: Philippe Mathieu-Daudé >>>>>> >>>>>> The previous attempt (commit f77147cd4de) doesn't work as >>> >>> ... ^ this comment :( >> >> Ahh - my tooling was confused having searched by the subject title ;-) > > Oh I see, I'll rename as: > "tests/meson: Only build softfloat objects if TCG is selected (again)". BTW you indeed reviewed/tested v1 of this patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg793900.html but after addressing Paolo's comments I preferred to remove your tags.