From: John Snow <jsnow@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
"Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Willian Rampazzo" <willianr@redhat.com>,
"Willian Rampazzo" <wrampazz@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH v6 25/25] python: add tox support
Date: Tue, 25 May 2021 16:25:37 -0400 [thread overview]
Message-ID: <9a50d093-9eea-850c-3d5d-bd44b0f45551@redhat.com> (raw)
In-Reply-To: <YK1ayNF0VTSJKa6O@localhost.localdomain>
On 5/25/21 4:15 PM, Cleber Rosa wrote:
> On Wed, May 12, 2021 at 07:12:41PM -0400, John Snow wrote:
>> This is intended to be a manually run, non-CI script.
>>
>> Use tox to test the linters against all python versions from 3.6 to
>> 3.9. This will only work if you actually have those versions installed
>> locally, but Fedora makes this easy:
>>
>>> sudo dnf install python36 python37 python38 python39
>>
>> Unlike the pipenv tests (make venv-check), this pulls "whichever"
>> versions of the python packages, so they are unpinned and may break as
>> time goes on. In the case that breakages are found, setup.cfg should be
>> amended accordingly to avoid the bad dependant versions, or the code
>> should be amended to work around the issue.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> python/README.rst | 2 ++
>> python/.gitignore | 1 +
>> python/Makefile | 7 ++++++-
>> python/setup.cfg | 1 +
>> python/tox.ini | 13 +++++++++++++
>> 5 files changed, 23 insertions(+), 1 deletion(-)
>> create mode 100644 python/tox.ini
>>
>
> This works as intended for me. A couple of notes / suggestions
> for future improvements:
>
> * `dnf install tox` pulled all the Python versions available (I
> assume as suggestions) automatically
>
> * tox.ini can be folded into setup.cfg
>
Done!
> * a custom container image with all those Python versions may be
> handy for running both the pipenv based job (along with the
> suggestions on the previous patch) and an on-demand,
> "allow_failure" tox based CI job.
>
Yeah, I was thinking this would be good, too!
I think at this point, it's going to be a follow-up, though. Because
ideally, yes, this SHOULD pass -- it's just that it needs a fairly
particular environment to run in, which is annoying, so it's here as an
optional-ish thing for now.
Maybe I'll make a new fedora:latest container that's meant solely for
testing python stuff, because it's just such a convenient distro for it.
Later, though.
> Other than those suggestions, this LGTM!
>
> Reviewed-by: Cleber Rosa <crosa@redhat.com>
> Tested-by: Cleber Rosa <crosa@redhat.com>
>
🎉
next prev parent reply other threads:[~2021-05-25 20:28 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 23:12 [PATCH v6 00/25] python: create installable package John Snow
2021-05-12 23:12 ` [PATCH v6 01/25] iotests/297: add --namespace-packages to mypy arguments John Snow
2021-05-12 23:12 ` [PATCH v6 02/25] python: create qemu packages John Snow
2021-05-18 14:31 ` Cleber Rosa
2021-05-21 17:15 ` Willian Rampazzo
2021-05-12 23:12 ` [PATCH v6 03/25] python: create utils sub-package John Snow
2021-05-18 15:12 ` Cleber Rosa
2021-05-18 15:20 ` John Snow
2021-05-21 17:18 ` Willian Rampazzo
2021-05-21 17:39 ` John Snow
2021-05-12 23:12 ` [PATCH v6 04/25] python: add qemu package installer John Snow
2021-05-21 4:00 ` Cleber Rosa
2021-05-21 15:52 ` John Snow
2021-05-12 23:12 ` [PATCH v6 05/25] python: add VERSION file John Snow
2021-05-12 23:12 ` [PATCH v6 06/25] python: add directory structure README.rst files John Snow
2021-05-25 2:33 ` Cleber Rosa
2021-05-25 17:14 ` John Snow
2021-05-25 20:30 ` Cleber Rosa
2021-05-12 23:12 ` [PATCH v6 07/25] python: add MANIFEST.in John Snow
2021-05-25 2:42 ` Cleber Rosa
2021-05-25 14:12 ` John Snow
2021-05-12 23:12 ` [PATCH v6 08/25] python: Add pipenv support John Snow
2021-05-12 23:12 ` [PATCH v6 09/25] python: add pylint import exceptions John Snow
2021-05-12 23:12 ` [PATCH v6 10/25] python: move pylintrc into setup.cfg John Snow
2021-05-12 23:12 ` [PATCH v6 11/25] python: add pylint to pipenv John Snow
2021-05-25 3:33 ` Cleber Rosa
2021-05-12 23:12 ` [PATCH v6 12/25] python: move flake8 config to setup.cfg John Snow
2021-05-12 23:12 ` [PATCH v6 13/25] python: add excluded dirs to flake8 config John Snow
2021-05-25 15:50 ` Cleber Rosa
2021-05-25 17:18 ` John Snow
2021-05-12 23:12 ` [PATCH v6 14/25] python: Add flake8 to pipenv John Snow
2021-05-12 23:12 ` [PATCH v6 15/25] python: move mypy.ini into setup.cfg John Snow
2021-05-25 15:52 ` Cleber Rosa
2021-05-12 23:12 ` [PATCH v6 16/25] python: add mypy to pipenv John Snow
2021-05-12 23:12 ` [PATCH v6 17/25] python: move .isort.cfg into setup.cfg John Snow
2021-05-12 23:12 ` [PATCH v6 18/25] python/qemu: add isort to pipenv John Snow
2021-05-25 15:56 ` Cleber Rosa
2021-05-25 17:21 ` John Snow
2021-05-25 20:34 ` Cleber Rosa
2021-05-12 23:12 ` [PATCH v6 19/25] python/qemu: add qemu package itself " John Snow
2021-05-12 23:12 ` [PATCH v6 20/25] python: add devel package requirements to setuptools John Snow
2021-05-25 16:13 ` Cleber Rosa
2021-05-25 17:43 ` John Snow
2021-05-25 20:38 ` Cleber Rosa
2021-05-12 23:12 ` [PATCH v6 21/25] python: add avocado-framework and tests John Snow
2021-05-25 18:58 ` Cleber Rosa
2021-05-12 23:12 ` [PATCH v6 22/25] python: add Makefile for some common tasks John Snow
2021-05-25 19:24 ` Cleber Rosa
2021-05-25 19:45 ` John Snow
2021-05-25 20:39 ` Cleber Rosa
2021-05-12 23:12 ` [PATCH v6 23/25] python: add .gitignore John Snow
2021-05-25 19:36 ` Cleber Rosa
2021-05-25 20:10 ` John Snow
2021-05-25 20:42 ` Cleber Rosa
2021-05-25 23:54 ` John Snow
2021-05-12 23:12 ` [PATCH v6 24/25] gitlab: add python linters to CI John Snow
2021-05-25 19:55 ` Cleber Rosa
2021-05-25 20:33 ` John Snow
2021-05-12 23:12 ` [PATCH v6 25/25] python: add tox support John Snow
2021-05-25 20:15 ` Cleber Rosa
2021-05-25 20:25 ` John Snow [this message]
2021-05-25 20:46 ` Cleber Rosa
2021-05-25 22:15 ` John Snow
2021-05-17 18:52 ` [PATCH v6 00/25] python: create installable package John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a50d093-9eea-850c-3d5d-bd44b0f45551@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).