From: John Snow <jsnow@redhat.com>
To: Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
vsementsov@virtuozzo.com, Juan Quintela <quintela@redhat.com>,
Wen Congyang <wencongyang2@huawei.com>,
Xie Changlong <xiechanglong.d@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 02/18] drive-backup: create do_backup_common
Date: Fri, 5 Jul 2019 13:35:23 -0400 [thread overview]
Message-ID: <9a5a1e1d-90bf-f884-475b-43935bd8f06b@redhat.com> (raw)
In-Reply-To: <04397b94-63d6-7d2c-77ad-964abe0e0310@redhat.com>
On 7/4/19 11:06 AM, Max Reitz wrote:
> On 03.07.19 23:55, John Snow wrote:
>> Create a common core that comprises the actual meat of what the backup API
>> boundary needs to do, and then switch drive-backup to use it.
>>
>> Questions:
>> - do_drive_backup now acquires and releases the aio_context in addition
>> to do_backup_common doing the same. Can I drop this from drive_backup?
>
> I wonder why you don’t just make it a requirement that
> do_backup_common() is called with the context acquired?
>
Oh, I remember: I wasn't actually sure if any of the calls that
drive-backup makes actually requires the AioContext. If that's true, no
reason to acquire it in two places and pass it in to the common function.
Probably bdrv_getlength and bdrv_refresh_filename both need it, though.
(Or at least, I can't promise they never wouldn't.)
--js
next prev parent reply other threads:[~2019-07-05 17:36 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 21:55 [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode John Snow
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 01/18] qapi/block-core: Introduce BackupCommon John Snow
2019-07-04 14:25 ` Max Reitz
2019-07-05 14:14 ` Markus Armbruster
2019-07-05 16:37 ` John Snow
2019-07-06 4:03 ` Markus Armbruster
2019-07-08 17:30 ` John Snow
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 02/18] drive-backup: create do_backup_common John Snow
2019-07-04 15:06 ` Max Reitz
2019-07-05 17:20 ` John Snow
2019-07-05 17:35 ` John Snow [this message]
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 03/18] blockdev-backup: utilize do_backup_common John Snow
2019-07-04 15:08 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 04/18] qapi: add BitmapSyncMode enum John Snow
2019-07-04 15:14 ` Max Reitz
2019-07-05 14:18 ` Markus Armbruster
2019-07-05 16:39 ` John Snow
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 05/18] block/backup: Add mirror sync mode 'bitmap' John Snow
2019-07-04 15:30 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 06/18] block/backup: add 'never' policy to bitmap sync mode John Snow
2019-07-04 15:34 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 07/18] hbitmap: Fix merge when b is empty, and result is not an alias of a John Snow
2019-07-04 15:36 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 08/18] hbitmap: enable merging across granularities John Snow
2019-07-04 15:40 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 09/18] block/dirty-bitmap: add bdrv_dirty_bitmap_merge_internal John Snow
2019-07-04 16:49 ` Max Reitz
2019-07-05 16:45 ` John Snow
2019-07-08 11:44 ` Max Reitz
2019-07-08 18:24 ` John Snow
2019-07-08 18:33 ` Max Reitz
2019-07-08 21:04 ` John Snow
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 10/18] block/dirty-bitmap: add bdrv_dirty_bitmap_get John Snow
2019-07-04 17:01 ` Max Reitz
2019-07-05 18:03 ` John Snow
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 11/18] block/backup: upgrade copy_bitmap to BdrvDirtyBitmap John Snow
2019-07-04 17:29 ` Max Reitz
2019-07-05 16:52 ` John Snow
2019-07-08 12:02 ` Max Reitz
2019-07-08 18:32 ` John Snow
2019-07-08 18:42 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 12/18] block/backup: add 'always' bitmap sync policy John Snow
2019-07-04 17:43 ` Max Reitz
2019-07-04 18:05 ` Max Reitz
2019-07-05 16:59 ` John Snow
2019-07-08 12:04 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 13/18] iotests: add testing shim for script-style python tests John Snow
2019-07-04 17:47 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 14/18] iotests: teach run_job to cancel pending jobs John Snow
2019-07-04 17:48 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 15/18] iotests: teach FilePath to produce multiple paths John Snow
2019-07-04 17:50 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 16/18] iotests: Add virtio-scsi device helper John Snow
2019-07-04 17:52 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 17/18] iotests: add test 257 for bitmap-mode backups John Snow
2019-07-04 17:56 ` Max Reitz
2019-07-03 21:55 ` [Qemu-devel] [PATCH v2 18/18] block/backup: loosen restriction on readonly bitmaps John Snow
2019-07-04 17:58 ` Max Reitz
2019-07-04 1:50 ` [Qemu-devel] [PATCH v2 00/18] bitmaps: introduce 'bitmap' sync mode no-reply
2019-07-04 4:13 ` John Snow
2019-07-04 2:05 ` no-reply
2019-07-04 15:07 ` no-reply
2019-07-04 18:58 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a5a1e1d-90bf-f884-475b-43935bd8f06b@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).