From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-block@nongnu.org
Subject: Re: [PATCH 9/9] osdep: Move memalign-related functions to their own header
Date: Tue, 1 Mar 2022 00:58:08 +0100 [thread overview]
Message-ID: <9a67f1d2-aed2-5bee-881a-8ff0d4cd0323@gmail.com> (raw)
In-Reply-To: <20220226180723.1706285-10-peter.maydell@linaro.org>
On 26/2/22 19:07, Peter Maydell wrote:
> Move the various memalign-related functions out of osdep.h and into
> their own header, which we include only where they are used.
> While we're doing this, add some brief documentation comments.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/qemu/memalign.h | 61 ++++++++++++++++++++++++++++++++++
> include/qemu/osdep.h | 18 ----------
> block/blkverify.c | 1 +
> block/block-copy.c | 1 +
> block/commit.c | 1 +
> block/crypto.c | 1 +
> block/dmg.c | 1 +
> block/export/fuse.c | 1 +
> block/file-posix.c | 1 +
> block/io.c | 1 +
> block/mirror.c | 1 +
> block/nvme.c | 1 +
> block/parallels-ext.c | 1 +
> block/parallels.c | 1 +
> block/qcow.c | 1 +
> block/qcow2-cache.c | 1 +
> block/qcow2-cluster.c | 1 +
> block/qcow2-refcount.c | 1 +
> block/qcow2-snapshot.c | 1 +
> block/qcow2.c | 1 +
> block/qed-l2-cache.c | 1 +
> block/qed-table.c | 1 +
> block/qed.c | 1 +
> block/quorum.c | 1 +
> block/raw-format.c | 1 +
> block/vdi.c | 1 +
> block/vhdx-log.c | 1 +
> block/vhdx.c | 1 +
> block/vmdk.c | 1 +
> block/vpc.c | 1 +
> block/win32-aio.c | 1 +
> hw/block/dataplane/xen-block.c | 1 +
> hw/block/fdc.c | 1 +
> hw/ide/core.c | 1 +
> hw/ppc/spapr.c | 1 +
> hw/ppc/spapr_softmmu.c | 1 +
> hw/scsi/scsi-disk.c | 1 +
> hw/tpm/tpm_ppi.c | 2 +-
> nbd/server.c | 1 +
> net/l2tpv3.c | 2 +-
> plugins/loader.c | 1 +
> qemu-img.c | 1 +
> qemu-io-cmds.c | 1 +
> qom/object.c | 1 +
> softmmu/physmem.c | 1 +
> target/i386/hvf/hvf.c | 1 +
> target/i386/kvm/kvm.c | 1 +
> tcg/region.c | 1 +
> tests/bench/atomic_add-bench.c | 1 +
> tests/bench/qht-bench.c | 1 +
> util/atomic64.c | 1 +
> util/memalign.c | 1 +
> util/qht.c | 1 +
> 53 files changed, 112 insertions(+), 20 deletions(-)
> create mode 100644 include/qemu/memalign.h
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
prev parent reply other threads:[~2022-03-01 0:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 18:07 [PATCH 0/9] Cleanup of qemu_oom_check() and qemu_memalign() Peter Maydell
2022-02-26 18:07 ` [PATCH 1/9] hw/usb/redirect.c: Stop using qemu_oom_check() Peter Maydell
2022-02-26 18:41 ` Peter Maydell
2022-02-27 0:26 ` Richard Henderson
2022-03-01 0:00 ` Philippe Mathieu-Daudé
2022-03-02 16:30 ` Eric Blake
2022-03-02 17:03 ` Peter Maydell
2022-02-26 18:07 ` [PATCH 2/9] util: Make qemu_oom_check() a static function Peter Maydell
2022-02-27 0:27 ` Richard Henderson
2022-03-01 0:00 ` Philippe Mathieu-Daudé
2022-02-26 18:07 ` [PATCH 3/9] util: Unify implementations of qemu_memalign() Peter Maydell
2022-02-27 0:29 ` Richard Henderson
2022-02-26 18:07 ` [PATCH 4/9] util/oslib-win32: Return NULL on qemu_try_memalign() with zero size Peter Maydell
2022-02-27 0:46 ` Richard Henderson
2022-02-27 0:56 ` Richard Henderson
2022-02-27 12:54 ` Peter Maydell
2022-02-27 18:36 ` Richard Henderson
2022-03-03 16:55 ` Peter Maydell
2022-03-03 23:02 ` Richard Henderson
2022-03-04 10:20 ` Peter Maydell
2022-02-26 18:07 ` [PATCH 5/9] meson.build: Don't misdetect posix_memalign() on Windows Peter Maydell
2022-02-27 0:52 ` Richard Henderson
2022-02-26 18:07 ` [PATCH 6/9] util: Share qemu_try_memalign() implementation between POSIX and Windows Peter Maydell
2022-02-27 0:56 ` Richard Henderson
2022-02-26 18:07 ` [PATCH 7/9] util: Use meson checks for valloc() and memalign() presence Peter Maydell
2022-02-27 0:58 ` Richard Henderson
2022-02-28 23:56 ` Philippe Mathieu-Daudé
2022-02-26 18:07 ` [PATCH 8/9] util: Put qemu_vfree() in memalign.c Peter Maydell
2022-02-27 1:05 ` Richard Henderson
2022-02-26 18:07 ` [PATCH 9/9] osdep: Move memalign-related functions to their own header Peter Maydell
2022-02-27 1:13 ` Richard Henderson
2022-02-28 23:58 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a67f1d2-aed2-5bee-881a-8ff0d4cd0323@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).