From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>,
Paolo Bonzini <pbonzini@redhat.com>,
alex.williamson@redhat.com, mst@redhat.com,
Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH qemu] kvm-irqchip: Only do explicit IRQ routing commit when IRQCHIP is in use
Date: Thu, 28 Jul 2016 12:20:14 +1000 [thread overview]
Message-ID: <9a71a204-4c40-9c5e-1346-dbf68a144de0@ozlabs.ru> (raw)
In-Reply-To: <20160727133245.GE18777@pxdev.xzpeter.org>
On 27/07/16 23:32, Peter Xu wrote:
> On Wed, Jul 27, 2016 at 09:29:07PM +0800, Peter Xu wrote:
>
> [...]
>
>>> This works too.
>>>
>>> You may also want to copy if(!kvm_gsi_routing_enabled()) from
>>> kvm_irqchip_add_msi_route() to align API (not needed in my case though). Or
>>> just check the result of these checks by if(!s->irq_routes) :)
>>> Thanks.
>>
>> Right. Do you like to post a v2 for this one? (since of course honor
>> is yours and fault is mine :) Please let me know if you want me to do
>> this for you. It'll be nice we have this fix asap so that less people
>> suffers.
>
> Btw, please ignore above message if you still prefer v1 and sure that
> it works in all cases. :)
I am totally fine with either fix (others may have opinions though), if you
really want your fix, please do so (and you can quote me as
"Reported-by"/"Tested-by" if you feel guilt which I do not think you should) :)
--
Alexey
next prev parent reply other threads:[~2016-07-28 2:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 7:51 [Qemu-devel] [PATCH qemu] kvm-irqchip: Only do explicit IRQ routing commit when IRQCHIP is in use Alexey Kardashevskiy
2016-07-27 8:53 ` Peter Xu
2016-07-27 13:14 ` Alexey Kardashevskiy
2016-07-27 13:29 ` Peter Xu
2016-07-27 13:32 ` Peter Xu
2016-07-28 2:20 ` Alexey Kardashevskiy [this message]
2016-08-02 19:48 ` Paolo Bonzini
2016-08-03 3:04 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a71a204-4c40-9c5e-1346-dbf68a144de0@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).