qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Paul Durrant" <paul@xen.org>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Matthew Rosato" <mjrosato@linux.ibm.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	qemu-s390x@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [PATCH for-8.0 9/9] hw: Remove device_legacy_reset()
Date: Fri, 4 Nov 2022 18:43:34 +0100	[thread overview]
Message-ID: <9a733e4e-98c5-9a0a-74eb-56db846f2dab@linaro.org> (raw)
In-Reply-To: <20221104161513.2455862-10-peter.maydell@linaro.org>

On 4/11/22 17:15, Peter Maydell wrote:
> The device_legacy_reset() function is now not used anywhere, so we
> can remove the implementation.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   include/hw/qdev-core.h |  9 ---------
>   hw/core/qdev.c         | 10 ----------
>   2 files changed, 19 deletions(-)

> -void device_legacy_reset(DeviceState *dev)
> -{
> -    DeviceClass *klass = DEVICE_GET_CLASS(dev);
> -
> -    trace_qdev_reset(dev, object_get_typename(OBJECT(dev)));

We can remove the "qdev_reset" entry in hw/core/trace-events.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> -    if (klass->reset) {
> -        klass->reset(dev);
> -    }
> -}


      reply	other threads:[~2022-11-04 17:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04 16:15 [PATCH for-8.0 0/9] reset: Remove some deprecated APIs Peter Maydell
2022-11-04 16:15 ` [PATCH for-8.0 1/9] hw/s390x/s390-pci-inst.c: Use device_cold_reset() to reset PCI devices Peter Maydell
2022-11-30 10:07   ` Philippe Mathieu-Daudé
2022-11-04 16:15 ` [PATCH for-8.0 2/9] hw/audio/intel-hda: don't reset codecs twice Peter Maydell
2022-11-04 16:15 ` [PATCH for-8.0 3/9] hw/audio/intel-hda: Drop unnecessary prototype Peter Maydell
2022-11-04 16:15 ` [PATCH for-8.0 4/9] hw/usb/hcd-xhci: Reset the XHCIState with device_cold_reset() Peter Maydell
2022-11-30 10:11   ` Philippe Mathieu-Daudé
2022-11-04 16:15 ` [PATCH for-8.0 5/9] pci: Use device_cold_reset() and bus_cold_reset() Peter Maydell
2022-11-04 17:39   ` Philippe Mathieu-Daudé
2022-11-04 16:15 ` [PATCH for-8.0 6/9] hw/hyperv/vmbus: " Peter Maydell
2022-11-10 20:33   ` Maciej S. Szmigiero
2022-11-30 10:12   ` Philippe Mathieu-Daudé
2022-11-04 16:15 ` [PATCH for-8.0 7/9] Replace use of qdev_reset_all() with device_cold_reset() Peter Maydell
2022-11-04 17:39   ` Paul Durrant
2022-11-30 10:14   ` Philippe Mathieu-Daudé
2022-11-04 16:15 ` [PATCH for-8.0 8/9] qdev: Remove qdev_reset_all() and qbus_reset_all() Peter Maydell
2022-11-04 17:46   ` Philippe Mathieu-Daudé
2022-11-04 16:15 ` [PATCH for-8.0 9/9] hw: Remove device_legacy_reset() Peter Maydell
2022-11-04 17:43   ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a733e4e-98c5-9a0a-74eb-56db846f2dab@linaro.org \
    --to=philmd@linaro.org \
    --cc=anthony.perard@citrix.com \
    --cc=berrange@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=kraxel@redhat.com \
    --cc=maciej.szmigiero@oracle.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=sstabellini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).