Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined

[Yi Min Zhao <zyimin@linux.ibm.com>]

在 2018/5/25 下午5:36, Eduardo Otubo 写道:
> On 05/25/2018 06:23 AM, Yi Min Zhao wrote:
>>
>>
>> 在 2018/5/24 下午9:40, Paolo Bonzini 写道:
>>> On 24/05/2018 09:53, Eduardo Otubo wrote:
>>>>>>> Thanks! But I have not got response from Paolo.  I have added 
>>>>>>> him to
>>>>>>> CC list.
>>>>>>>
>>>>>>   I'll just wait one more ACK and will send a pull request on the
>>>>>> seccomp queue. Thanks for the contribution.
>>>>>>
>>>>>>
>>>>> So... what I should do is wait?
>>>>>
>>>> Yes, even though I think we're safe to proceed without his explicit 
>>>> ack.
>>> The patch is okay; however, as a follow-up, you could consider moving
>>> all the CONFIG_SECCOMP code to qemu-seccomp.c.
>>>
>>> This way, the only #ifdef remains the one around qemu_opts_foreach.
>>>
>>> Paolo
>>>
>>>
>> Thanks for your comment! Indeed, moving to the single C file is much 
>> more clear.
>> I will do this after this patch.
>>
>> @Otubo, what about next step?
>>
>>
> If you're willing to send v3 with the changes Paolo suggested, I can 
> wait to send the pull request. No worries.
>
>
OK. I will update the new version with Paolo's suggestion.