From: Laurent Vivier <laurent@vivier.eu>
To: Wei Yang <richardw.yang@linux.intel.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: peter.maydell@linaro.org, philmd@redhat.com, mjt@tls.msk.ru,
imammedo@redhat.com, eblake@redhat.com, sgarzare@redhat.com
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v6 2/2] CODING_STYLE: indent example code as all others
Date: Thu, 11 Apr 2019 21:42:39 +0200 [thread overview]
Message-ID: <9a8d8585-4113-8ffe-d025-abd49c208428@vivier.eu> (raw)
In-Reply-To: <20190304071631.27567-3-richardw.yang@linux.intel.com>
On 04/03/2019 08:16, Wei Yang wrote:
> All the example code are indented with four spaces except this one.
>
> Fix this by adding four spaces here.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> CODING_STYLE | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> index 90321e9c28..cb8edcbb36 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -147,10 +147,10 @@ block to a separate function altogether.
> When comparing a variable for (in)equality with a constant, list the
> constant on the right, as in:
>
> -if (a == 1) {
> - /* Reads like: "If a equals 1" */
> - do_something();
> -}
> + if (a == 1) {
> + /* Reads like: "If a equals 1" */
> + do_something();
> + }
>
> Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read.
> Besides, good compilers already warn users when '==' is mis-typed as '=',
>
Applied to my trivial-patches branch.
Thanks,
Laurent
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <laurent@vivier.eu>
To: Wei Yang <richardw.yang@linux.intel.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, imammedo@redhat.com,
philmd@redhat.com, sgarzare@redhat.com
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v6 2/2] CODING_STYLE: indent example code as all others
Date: Thu, 11 Apr 2019 21:42:39 +0200 [thread overview]
Message-ID: <9a8d8585-4113-8ffe-d025-abd49c208428@vivier.eu> (raw)
Message-ID: <20190411194239.g8LSxXqRtIJvD74tJbipB-Ql3Y3axo7lhwuRVTvwObA@z> (raw)
In-Reply-To: <20190304071631.27567-3-richardw.yang@linux.intel.com>
On 04/03/2019 08:16, Wei Yang wrote:
> All the example code are indented with four spaces except this one.
>
> Fix this by adding four spaces here.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> CODING_STYLE | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> index 90321e9c28..cb8edcbb36 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -147,10 +147,10 @@ block to a separate function altogether.
> When comparing a variable for (in)equality with a constant, list the
> constant on the right, as in:
>
> -if (a == 1) {
> - /* Reads like: "If a equals 1" */
> - do_something();
> -}
> + if (a == 1) {
> + /* Reads like: "If a equals 1" */
> + do_something();
> + }
>
> Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read.
> Besides, good compilers already warn users when '==' is mis-typed as '=',
>
Applied to my trivial-patches branch.
Thanks,
Laurent
next prev parent reply other threads:[~2019-04-11 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 7:16 [Qemu-devel] [PATCH v6 0/2] CODING_STYLE: trivial update Wei Yang
2019-03-04 7:16 ` [Qemu-devel] [PATCH v6 1/2] CODING_STYLE: specify the indent rule for multiline code Wei Yang
2019-03-04 14:25 ` Igor Mammedov
2019-04-11 19:42 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-04-11 19:42 ` Laurent Vivier
2019-03-04 7:16 ` [Qemu-devel] [PATCH v6 2/2] CODING_STYLE: indent example code as all others Wei Yang
2019-04-11 19:42 ` Laurent Vivier [this message]
2019-04-11 19:42 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
2019-03-04 7:59 ` [Qemu-devel] [PATCH v6 0/2] CODING_STYLE: trivial update Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8d8585-4113-8ffe-d025-abd49c208428@vivier.eu \
--to=laurent@vivier.eu \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richardw.yang@linux.intel.com \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).