From: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: aurelien@aurel32.net, peter.maydell@linaro.org,
alex.bennee@linaro.org,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] fpu: Add conversions between bfloat16 and [u]int8
Date: Wed, 13 Sep 2023 17:54:00 +0800 [thread overview]
Message-ID: <9aa175fb-24f2-3cd8-7ab4-13a6dc640993@linux.alibaba.com> (raw)
In-Reply-To: <20230531065458.2082-1-zhiwei_liu@linux.alibaba.com>
Hi Richard,
Can you pick it to your tree?
Thanks,
Zhiwei
On 2023/5/31 14:54, LIU Zhiwei wrote:
> We missed these functions when upstreaming the bfloat16 support.
>
> Signed-off-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> ---
> fpu/softfloat.c | 58 +++++++++++++++++++++++++++++++++++++++++
> include/fpu/softfloat.h | 12 +++++++++
> 2 files changed, 70 insertions(+)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 108f9cb224..576b026f4e 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -3113,6 +3113,15 @@ int64_t float64_to_int64_scalbn(float64 a, FloatRoundMode rmode, int scale,
> return parts_float_to_sint(&p, rmode, scale, INT64_MIN, INT64_MAX, s);
> }
>
> +int8_t bfloat16_to_int8_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,
> + float_status *s)
> +{
> + FloatParts64 p;
> +
> + bfloat16_unpack_canonical(&p, a, s);
> + return parts_float_to_sint(&p, rmode, scale, INT8_MIN, INT8_MAX, s);
> +}
> +
> int16_t bfloat16_to_int16_scalbn(bfloat16 a, FloatRoundMode rmode, int scale,
> float_status *s)
> {
> @@ -3379,6 +3388,11 @@ int64_t floatx80_to_int64_round_to_zero(floatx80 a, float_status *s)
> return floatx80_to_int64_scalbn(a, float_round_to_zero, 0, s);
> }
>
> +int8_t bfloat16_to_int8(bfloat16 a, float_status *s)
> +{
> + return bfloat16_to_int8_scalbn(a, s->float_rounding_mode, 0, s);
> +}
> +
> int16_t bfloat16_to_int16(bfloat16 a, float_status *s)
> {
> return bfloat16_to_int16_scalbn(a, s->float_rounding_mode, 0, s);
> @@ -3394,6 +3408,11 @@ int64_t bfloat16_to_int64(bfloat16 a, float_status *s)
> return bfloat16_to_int64_scalbn(a, s->float_rounding_mode, 0, s);
> }
>
> +int8_t bfloat16_to_int8_round_to_zero(bfloat16 a, float_status *s)
> +{
> + return bfloat16_to_int8_scalbn(a, float_round_to_zero, 0, s);
> +}
> +
> int16_t bfloat16_to_int16_round_to_zero(bfloat16 a, float_status *s)
> {
> return bfloat16_to_int16_scalbn(a, float_round_to_zero, 0, s);
> @@ -3503,6 +3522,15 @@ uint64_t float64_to_uint64_scalbn(float64 a, FloatRoundMode rmode, int scale,
> return parts_float_to_uint(&p, rmode, scale, UINT64_MAX, s);
> }
>
> +uint8_t bfloat16_to_uint8_scalbn(bfloat16 a, FloatRoundMode rmode,
> + int scale, float_status *s)
> +{
> + FloatParts64 p;
> +
> + bfloat16_unpack_canonical(&p, a, s);
> + return parts_float_to_uint(&p, rmode, scale, UINT8_MAX, s);
> +}
> +
> uint16_t bfloat16_to_uint16_scalbn(bfloat16 a, FloatRoundMode rmode,
> int scale, float_status *s)
> {
> @@ -3728,6 +3756,11 @@ Int128 float128_to_uint128_round_to_zero(float128 a, float_status *s)
> return float128_to_uint128_scalbn(a, float_round_to_zero, 0, s);
> }
>
> +uint8_t bfloat16_to_uint8(bfloat16 a, float_status *s)
> +{
> + return bfloat16_to_uint8_scalbn(a, s->float_rounding_mode, 0, s);
> +}
> +
> uint16_t bfloat16_to_uint16(bfloat16 a, float_status *s)
> {
> return bfloat16_to_uint16_scalbn(a, s->float_rounding_mode, 0, s);
> @@ -3743,6 +3776,11 @@ uint64_t bfloat16_to_uint64(bfloat16 a, float_status *s)
> return bfloat16_to_uint64_scalbn(a, s->float_rounding_mode, 0, s);
> }
>
> +uint8_t bfloat16_to_uint8_round_to_zero(bfloat16 a, float_status *s)
> +{
> + return bfloat16_to_uint8_scalbn(a, float_round_to_zero, 0, s);
> +}
> +
> uint16_t bfloat16_to_uint16_round_to_zero(bfloat16 a, float_status *s)
> {
> return bfloat16_to_uint16_scalbn(a, float_round_to_zero, 0, s);
> @@ -3898,6 +3936,11 @@ bfloat16 int16_to_bfloat16_scalbn(int16_t a, int scale, float_status *status)
> return int64_to_bfloat16_scalbn(a, scale, status);
> }
>
> +bfloat16 int8_to_bfloat16_scalbn(int8_t a, int scale, float_status *status)
> +{
> + return int64_to_bfloat16_scalbn(a, scale, status);
> +}
> +
> bfloat16 int64_to_bfloat16(int64_t a, float_status *status)
> {
> return int64_to_bfloat16_scalbn(a, 0, status);
> @@ -3913,6 +3956,11 @@ bfloat16 int16_to_bfloat16(int16_t a, float_status *status)
> return int64_to_bfloat16_scalbn(a, 0, status);
> }
>
> +bfloat16 int8_to_bfloat16(int8_t a, float_status *status)
> +{
> + return int64_to_bfloat16_scalbn(a, 0, status);
> +}
> +
> float128 int128_to_float128(Int128 a, float_status *status)
> {
> FloatParts128 p = { };
> @@ -4108,6 +4156,11 @@ bfloat16 uint16_to_bfloat16_scalbn(uint16_t a, int scale, float_status *status)
> return uint64_to_bfloat16_scalbn(a, scale, status);
> }
>
> +bfloat16 uint8_to_bfloat16_scalbn(uint8_t a, int scale, float_status *status)
> +{
> + return uint64_to_bfloat16_scalbn(a, scale, status);
> +}
> +
> bfloat16 uint64_to_bfloat16(uint64_t a, float_status *status)
> {
> return uint64_to_bfloat16_scalbn(a, 0, status);
> @@ -4123,6 +4176,11 @@ bfloat16 uint16_to_bfloat16(uint16_t a, float_status *status)
> return uint64_to_bfloat16_scalbn(a, 0, status);
> }
>
> +bfloat16 uint8_to_bfloat16(uint8_t a, float_status *status)
> +{
> + return uint64_to_bfloat16_scalbn(a, 0, status);
> +}
> +
> float128 uint64_to_float128(uint64_t a, float_status *status)
> {
> FloatParts128 p;
> diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
> index 3dcf20e3a2..6d02f619d0 100644
> --- a/include/fpu/softfloat.h
> +++ b/include/fpu/softfloat.h
> @@ -366,6 +366,8 @@ float32 bfloat16_to_float32(bfloat16, float_status *status);
> bfloat16 float64_to_bfloat16(float64 a, float_status *status);
> float64 bfloat16_to_float64(bfloat16 a, float_status *status);
>
> +int8_t bfloat16_to_int8_scalbn(bfloat16, FloatRoundMode,
> + int, float_status *status);
> int16_t bfloat16_to_int16_scalbn(bfloat16, FloatRoundMode,
> int, float_status *status);
> int32_t bfloat16_to_int32_scalbn(bfloat16, FloatRoundMode,
> @@ -373,14 +375,18 @@ int32_t bfloat16_to_int32_scalbn(bfloat16, FloatRoundMode,
> int64_t bfloat16_to_int64_scalbn(bfloat16, FloatRoundMode,
> int, float_status *status);
>
> +int8_t bfloat16_to_int8(bfloat16, float_status *status);
> int16_t bfloat16_to_int16(bfloat16, float_status *status);
> int32_t bfloat16_to_int32(bfloat16, float_status *status);
> int64_t bfloat16_to_int64(bfloat16, float_status *status);
>
> +int8_t bfloat16_to_int8_round_to_zero(bfloat16, float_status *status);
> int16_t bfloat16_to_int16_round_to_zero(bfloat16, float_status *status);
> int32_t bfloat16_to_int32_round_to_zero(bfloat16, float_status *status);
> int64_t bfloat16_to_int64_round_to_zero(bfloat16, float_status *status);
>
> +uint8_t bfloat16_to_uint8_scalbn(bfloat16 a, FloatRoundMode,
> + int, float_status *status);
> uint16_t bfloat16_to_uint16_scalbn(bfloat16 a, FloatRoundMode,
> int, float_status *status);
> uint32_t bfloat16_to_uint32_scalbn(bfloat16 a, FloatRoundMode,
> @@ -388,24 +394,30 @@ uint32_t bfloat16_to_uint32_scalbn(bfloat16 a, FloatRoundMode,
> uint64_t bfloat16_to_uint64_scalbn(bfloat16 a, FloatRoundMode,
> int, float_status *status);
>
> +uint8_t bfloat16_to_uint8(bfloat16 a, float_status *status);
> uint16_t bfloat16_to_uint16(bfloat16 a, float_status *status);
> uint32_t bfloat16_to_uint32(bfloat16 a, float_status *status);
> uint64_t bfloat16_to_uint64(bfloat16 a, float_status *status);
>
> +uint8_t bfloat16_to_uint8_round_to_zero(bfloat16 a, float_status *status);
> uint16_t bfloat16_to_uint16_round_to_zero(bfloat16 a, float_status *status);
> uint32_t bfloat16_to_uint32_round_to_zero(bfloat16 a, float_status *status);
> uint64_t bfloat16_to_uint64_round_to_zero(bfloat16 a, float_status *status);
>
> +bfloat16 int8_to_bfloat16_scalbn(int8_t a, int, float_status *status);
> bfloat16 int16_to_bfloat16_scalbn(int16_t a, int, float_status *status);
> bfloat16 int32_to_bfloat16_scalbn(int32_t a, int, float_status *status);
> bfloat16 int64_to_bfloat16_scalbn(int64_t a, int, float_status *status);
> +bfloat16 uint8_to_bfloat16_scalbn(uint8_t a, int, float_status *status);
> bfloat16 uint16_to_bfloat16_scalbn(uint16_t a, int, float_status *status);
> bfloat16 uint32_to_bfloat16_scalbn(uint32_t a, int, float_status *status);
> bfloat16 uint64_to_bfloat16_scalbn(uint64_t a, int, float_status *status);
>
> +bfloat16 int8_to_bfloat16(int8_t a, float_status *status);
> bfloat16 int16_to_bfloat16(int16_t a, float_status *status);
> bfloat16 int32_to_bfloat16(int32_t a, float_status *status);
> bfloat16 int64_to_bfloat16(int64_t a, float_status *status);
> +bfloat16 uint8_to_bfloat16(uint8_t a, float_status *status);
> bfloat16 uint16_to_bfloat16(uint16_t a, float_status *status);
> bfloat16 uint32_to_bfloat16(uint32_t a, float_status *status);
> bfloat16 uint64_to_bfloat16(uint64_t a, float_status *status);
next prev parent reply other threads:[~2023-09-13 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 6:54 [PATCH] fpu: Add conversions between bfloat16 and [u]int8 LIU Zhiwei
[not found] ` <686ffc58-4d2d-f9a9-49b0-722dcedc2dc5@linaro.org>
2023-06-01 1:49 ` LIU Zhiwei
2023-09-13 9:54 ` LIU Zhiwei [this message]
2023-09-15 12:35 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aa175fb-24f2-3cd8-7ab4-13a6dc640993@linux.alibaba.com \
--to=zhiwei_liu@linux.alibaba.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).