From: David Hildenbrand <david@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 11/13] nvdimm: allow setting the label-size to 0
Date: Mon, 18 Jun 2018 14:04:59 +0200 [thread overview]
Message-ID: <9ab8d32c-a558-b460-67ad-a7c6fea638b6@redhat.com> (raw)
In-Reply-To: <20180618140308.0fe78716@redhat.com>
On 18.06.2018 14:03, Igor Mammedov wrote:
> On Fri, 15 Jun 2018 16:04:46 +0200
> David Hildenbrand <david@redhat.com> wrote:
>
>> It is inititally 0, so setting it to 0 should be allowed, too.
> I'm not sure if we need to permit it.
> By default labels are disabled (label-size=0) and user are supposed to provide
> this option if labels should be enabled with a valid size.
>
> it could be confusing for user when asking for label and not getting it.
>
> I suggest to drop this patch, it's not really related to this series
> nor required for your future work.
>
As I just want to finally get this stuff off my table, I agree to
whatever you say.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2018-06-18 12:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 14:04 [Qemu-devel] [PATCH v3 00/13] pc-dimm: next bunch of cleanups David Hildenbrand
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 01/13] pc-dimm: remove leftover "struct pc_dimms_capacity" David Hildenbrand
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 02/13] pc: rename pc_dimm_(plug|unplug|...)* into pc_memory_(plug|unplug|...)* David Hildenbrand
2018-06-18 0:39 ` David Gibson
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 03/13] pc-dimm: rename pc_dimm_memory_* to pc_dimm_* David Hildenbrand
2018-06-18 0:39 ` David Gibson
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 04/13] pc-dimm: remove pc_dimm_get_free_slot() from header David Hildenbrand
2018-06-18 0:41 ` David Gibson
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 05/13] pc: factor out pc specific dimm checks into pc_memory_pre_plug() David Hildenbrand
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 06/13] nvdimm: no need to overwrite get_vmstate_memory_region() David Hildenbrand
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 07/13] hostmem: drop error variable from host_memory_backend_get_memory() David Hildenbrand
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region() David Hildenbrand
2018-06-18 0:46 ` David Gibson
2018-06-18 11:47 ` Igor Mammedov
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 09/13] nvdimm: convert "unarmed" into a static property David Hildenbrand
2018-06-18 0:48 ` David Gibson
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer David Hildenbrand
2018-06-18 0:49 ` David Gibson
2018-06-18 10:51 ` David Hildenbrand
2018-06-18 12:42 ` Igor Mammedov
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 11/13] nvdimm: allow setting the label-size to 0 David Hildenbrand
2018-06-16 2:05 ` Haozhong Zhang
2018-06-18 10:49 ` David Hildenbrand
2018-06-18 12:03 ` Igor Mammedov
2018-06-18 12:04 ` David Hildenbrand [this message]
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 12/13] nvdimm: make get_memory_region() perform checks and initialization David Hildenbrand
2018-06-18 12:43 ` Igor Mammedov
2018-06-15 14:04 ` [Qemu-devel] [PATCH v3 13/13] pc-dimm: get_memory_region() will not fail after realize David Hildenbrand
2018-06-18 0:52 ` David Gibson
2018-06-18 12:32 ` [Qemu-devel] [PATCH v3 00/13] pc-dimm: next bunch of cleanups David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ab8d32c-a558-b460-67ad-a7c6fea638b6@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).