From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0511BC47258 for ; Fri, 26 Jan 2024 00:10:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rT9n1-0001Tw-Jd; Thu, 25 Jan 2024 19:09:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rT9mv-0001Td-T1; Thu, 25 Jan 2024 19:09:41 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rT9mt-0000QX-VV; Thu, 25 Jan 2024 19:09:41 -0500 Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40PNvJla024142; Fri, 26 Jan 2024 00:09:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=lthent0jMfwPWB1p4SgTBWPZCcG/fXMVBuiZXdjd3Uk=; b=KbllQG/nIeTZa6o2ZgGoh1l0P86FNwbM5fmvOdWKndAFgA4c838luYTtoYC6cXThjOal 6ejtHUijfdK7MrWvJcUZnS96YLeJG0fVcDfkTSfA2eCrlhXuMazJqqbVx+hVTp0lUcOz u/lxUXZ1NeVDXqpYZSnbRdfUuV20Of2yHYvZ/s987rGSyK4o4BrqcqcgTb2kLsBPFsCS YaZ5zdZQeex773llqxq1HKQIIKJ04iLRJblyz8eAyV0rbL6L30ty2/+rtn8ZNRqa3Ult LB2aq6nXGBPWVgwQb30SSKSwJgNDI+Udx6QWNpJKAnSmIPluLhEy2FxqPnap11YYa9Qd Lg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vv1s10aq1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 00:09:21 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40PNxLWW030893; Fri, 26 Jan 2024 00:09:20 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vv1s10apr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 00:09:20 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 40PNL6AT025291; Fri, 26 Jan 2024 00:09:19 GMT Received: from smtprelay04.dal12v.mail.ibm.com ([172.16.1.6]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3vrtqkq5ne-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 00:09:19 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay04.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 40Q09JMX27984328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Jan 2024 00:09:19 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA3DA58050; Fri, 26 Jan 2024 00:09:18 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 267515805E; Fri, 26 Jan 2024 00:09:18 +0000 (GMT) Received: from [9.61.160.70] (unknown [9.61.160.70]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 26 Jan 2024 00:09:18 +0000 (GMT) Message-ID: <9ab956ee-f753-4829-be2d-31f86b55db0d@linux.ibm.com> Date: Thu, 25 Jan 2024 18:09:17 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 3/9] hw/fsi: Introduce IBM's cfam Content-Language: en-US To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, peter.maydell@linaro.org, andrew@codeconstruct.com.au, joel@jms.id.au, pbonzini@redhat.com, marcandre.lureau@redhat.com, berrange@redhat.com, thuth@redhat.com, philmd@linaro.org, lvivier@redhat.com Cc: qemu-arm@nongnu.org, Andrew Jeffery References: <20240110231537.1654478-1-ninad@linux.ibm.com> <20240110231537.1654478-4-ninad@linux.ibm.com> From: Ninad Palsule In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: YviQhnMnh9Nwujn3q090ahJnGTq5u-g- X-Proofpoint-ORIG-GUID: DHgwnyRGUrtZJNodR7T9ZF2mCMWmmF7m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-25_14,2024-01-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 impostorscore=0 mlxlogscore=880 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401250174 Received-SPF: pass client-ip=148.163.156.1; envelope-from=ninad@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hello Cedric, >> >> [ clg: - moved object FSIScratchPad under FSICFAMState >>         - moved FSIScratchPad code under cfam.c >>         - introduced fsi_cfam_instance_init() >>         - reworked fsi_cfam_realize() ] > > Move the list down before my S-o-b. Done. > >> >> + >> +/* Valid, slots, version, type, crc */ >> +#define CFAM_CONFIG_REG_FSI_SLAVE (ENGINE_CONFIG_NEXT       | \ >> + 0x00010000               | \ >> + 0x00005000               | \ >> + ENGINE_CONFIG_TYPE_FSI   | \ >> +                                            0x0000000a) >> + >> +/* Valid, slots, version, type, crc */ >> +#define CFAM_CONFIG_REG_SCRATCHPAD (ENGINE_CONFIG_NEXT       | \ >> + 0x00010000               | \ >> + 0x00001000               | \ >> + ENGINE_CONFIG_TYPE_SCRATCHPAD | \ >> +                                            0x00000007) > > I was expecting a macro taking argument to build the config reg value > of each sub engine but that's fine also. Added single macro. > >> >> + >> +    memory_region_add_subregion(&cfam->mr, 0, &cfam->config_iomem); >> +    memory_region_add_subregion(&cfam->mr, 0x800, &slave->iomem); >> +    memory_region_add_subregion(&cfam->mr, 0xc00, &cfam->lbus.mr); >> + >> +    /* Add scratchpad engine */ >> +    if (!qdev_realize(DEVICE(&cfam->scratchpad), BUS(&cfam->lbus), >> +                                errp)) { > > could be a single line. Yep, Made it a single line. Thanks for the review. Regards, Ninad